[#10878] - Don't pass params by reference
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10878
- Diff
- mbabker:references
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
ConfigModelComponent::save() dispatches the onExtension(Before|After)Save events passing the JTable object by reference. This is contradictory to how the onXXX(Before|After)Save events are dispatched in JModelAdmin. The references are removed.
Testing Instructions
Events are correctly dispatched and processed when saving an extension record (com_config component, com_modules, and com_plugins as examples).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
BTW, reference is used also by MenusModelItem::save() and 17 other places.
Here's regular expression to find out all the instances when table is passed as reference: \$dispatcher->trigger\(.*?&\$table
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10878.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 18:05:02 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 8d78fd3
Tested with my plugin, event methods are called properly,
also it is not only about how events are called in JModelAdmin.
The signatures of the methods do no have the reference:
e.g.