[#10874] - com_finder does not mark findings when word contains diacritical characters
- Closed
- 19 Jan 2018
- Medium
- Build: master
- # 10874
Steps to reproduce the issue
Write an article that contains words with diacritical (non-English) characters, e.g. verhüten, Königsweg, überschauen, Hintertür
Expected result
Entering one of these words into the searchbox will find the words and display them in the context as expected, however they get not marked as search results as 'normal' words would.
Actual result
Article displayed in context, without found word marked.
System information (as much as possible)
Joomla 3.5.1, Apache, PHP 7.0.0, MySQL 5.5.49 on MAMP for Windows
Additional comments
That's what I meant, the words don't get highlighted.
brianteeman
- | Category | Components | ⇒ | Components Search |
@chrisdavenport
Can you look at this?
Confirmed.
The ?highlight argument is not correctly encoding the multibyte characters. This can be fixed by using an optional 2nd argument to json_encode so components/com_finder/views/search/tmpl/default_result.php line 45 becomes:
$route .= '&highlight=' . base64_encode(json_encode($this->query->highlight, JSON_UNESCAPED_UNICODE));
Unfortunately, JSON_UNESCAPED_UNICODE is only available from PHP 5.4 onwards so you'll need to jump through some hoops if you want to fix the problem in PHP 5.3 too.
However, even with the above fix, the highlighter still doesn't work. I'm guessing that highlight.js doesn't support UTF-8 characters properly. You'll need a JavaScript expert to fix that one!
I'm very short of time at the moment, so I don't think I can take it much further right now. Hopefully, someone can run with it.
@ChrisHoefliger is this Issue resolved by #13498?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10874.
| Status | New | ⇒ | Information Required |
@franz-wohlkoenig Just tested in J! 3.7 Beta 4. It's not being resolved, sitauation still the same. Words without Umlauts get highlighted, words with Umlauts will be found, but no highlighting.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10874.
| Status | Information Required | ⇒ | Needs Review |
thanks @ChrisHoefliger set Status on "Needs Review" on Issue Tracker.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10874.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-19 21:53:19 |
| Closed_By | ⇒ | Quy |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/10874
It appears to be fixed as of v3.8.4-dev.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10874.
you mean that they are not highlighted?