Feeling Lucky
?
[#10859] - add .editorconfig to .gitignore
- Fixed in Code Base
- 15 Jul 2016
- Medium
- Build: staging
- # 10859
- Diff
- wojsmol:editorconfig-gitignore
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue improvment .
Summary of Changes
Simple PR to add .editorconfig to .gitignore
Testing Instructions
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
wojsmol
- comment
- 19 Jun 2016
I added .editorconfig to gitignore taking into account the current situation where the file is not a in the repository joomla/joomla-cms. If .editorconfig been added to joomla/joomla-cms then of course it should be added to the build/build.php and removed from a .gitignore.
piotr-cz
- comment
- 19 Jun 2016
True, as long as the file belongs to other repo, it should be excluded.
brianteeman
- | Category | ⇒ | Code style |
grhcj
- comment
- 15 Jul 2016
I have tested this item
On Review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10859.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-15 13:56:31 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
This file shouldn't be placed in
.gitignore, becase developers are supposed to retrieve it during git clone.But it should be excluded during package build process within the build.php file. I usually add this in the
.gitattributesfileI've added it into the Joomla! Coding-standards repo here, but I guess there is no harm placing it inside Joomla! repo.