Feeling Lucky
?
[#10850] - Code review on com_finder component
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10850
- Diff
- mbabker:review-finder-component
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR is a general overview and cleanup of some code structure and doc blocks in the admin com_finder component. Changes of note:
- Doc blocks cleaned up some to follow standard
- Return the results of the view's
display()methods to be consistent with the documented return - Not using variables for items only referenced once
- Use
Joomla\Utilities\ArrayHelperinstead ofJArrayHelper - Removed
static $logfrom methods instantiating a logger;JLog::addLogger()has no return value so the variable cannot be populated with data - Use of the
JApplicationWebAPI in the indexer for building and sending the application response - Support late static bindings in the indexer API classes, reference private members as
self:: - Renamed private members with a leading underscore for code style compliance
- A query that was executed twice in
FinderModelIndex::getPluginState()is now only executed once
Testing Instructions
The admin com_finder component should continue to function correctly
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style Components |
PhilETaylor
- comment
- 17 Jun 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10850.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 17 Jun 2016
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 18:54:41 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 1ef4a29
Did a code review.
Tested a little the finder in backend (index, views, new filter, etc) and frontend (search).
all seems fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10850.