? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
16 Jun 2016

Summary of Changes

Deprecates the $_PROFILER global variable. The profiler should be accessed via the JProfiler API. Replaced existing uses of the global variable with locally scoped versions.

Testing Instructions

While in debug mode, the application profiler should continue to work normally.

avatar mbabker mbabker - open - 16 Jun 2016
avatar mbabker mbabker - change - 16 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 16 Jun 2016
Category Libraries
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Jun 2016

tested with success

but notice that _PROFILER also exists in https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/views/search/view.html.php

Shouldnt it be changed here too?

avatar mbabker
mbabker - comment - 16 Jun 2016

Yep. Didn't find that one as my search was only for the variable and not a
structure like that.

On Thursday, June 16, 2016, andrepereiradasilva notifications@github.com
wrote:

tesed with sucess

but notice that _PROFILER also exists in
https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/views/search/view.html.php

Shouldnt it be changed here too?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10845 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAWfoWVY3CSV9JA1SzgyHpID7OGhfqtZks5qMchfgaJpZM4I32eN
.

avatar andrepereiradasilva andrepereiradasilva - test_item - 17 Jun 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 Jun 2016

I have tested this item successfully on 0a77c11


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10845.

avatar alikon alikon - test_item - 23 Jun 2016 - Tested successfully
avatar alikon
alikon - comment - 23 Jun 2016

I have tested this item successfully on 0a77c11


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10845.

avatar brianteeman brianteeman - change - 23 Jun 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 Jun 2016

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10845.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Category Libraries Administration Front End Components Libraries Plugins
avatar rdeutz rdeutz - change - 14 Aug 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-08-14 16:53:12
Closed_By rdeutz
avatar rdeutz rdeutz - close - 14 Aug 2016
avatar rdeutz rdeutz - merge - 14 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - close - 14 Aug 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment