Feeling Lucky
?
[#10839] - Declare the document variable
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- # 10839
- Diff
- mbabker:JViewLegacy-document
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
JControllerLegacy::display() injects a JDocument instance into JViewLegacy objects here. There is not a JViewLegacy::$document class member variable defined. Now there is.
Testing Instructions
Review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
mbabker
- comment
- 16 Jun 2016
Someone should do it for all of the properties here, I didn't because none have it and I don't feel like digging back to determine when the variable was actually introduced.
grhcj
- comment
- 17 Jun 2016
I have tested this item
On code Review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10839.
zero-24
- comment
- 17 Jun 2016
I have tested this item
On code Review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10839.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 17 Jun 2016
| Labels |
Added:
?
|
||
photodude
- comment
- 19 Jun 2016
I think all of the variables were introduced at or before platform 11.1, and before the use of github for the version histories.
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 18:56:30 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Should we include a @since tag?