? ? Success

User tests: Successful: Unsuccessful:

avatar helvecio
helvecio
16 Jun 2016

String changed:

COM_TAGS_TAG_VIEW_LIST_DESC

Summary of Changes

I propose that the sentence "Displays a compact list of items that have been tagged with the selected tags" is changed to "Displays a compact list of items that have been assigned to the selected tags". The idea here is to avoid the use of the same or similar words while keeping the message clear.

avatar helvecio helvecio - open - 16 Jun 2016
avatar helvecio helvecio - change - 16 Jun 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 16 Jun 2016

I understand what you are trying to do but I dont agree that this makes it clearer. What about going even simpler

COM_TAGS_TAG_VIEW_LIST_DESC="Displays a compact list of items with the selected tags."


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10837.

avatar brianteeman brianteeman - change - 16 Jun 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 16 Jun 2016
Labels
avatar helvecio helvecio - change - 16 Jun 2016
Labels
avatar helvecio
helvecio - comment - 16 Jun 2016

Even simpler and even better. Thank you! I've already added to the pull-request.

avatar brianteeman brianteeman - test_item - 16 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 Jun 2016

I have tested this item successfully on cab3663


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10837.

avatar zero-24 zero-24 - test_item - 16 Jun 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 16 Jun 2016

I have tested this item successfully on cab3663

Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10837.

avatar zero-24 zero-24 - change - 16 Jun 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 16 Jun 2016

RTC :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10837.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Jun 2016
Labels Added: ?
avatar helvecio
helvecio - comment - 17 Jun 2016

Newbie question: now all checks have passed, should I close and comment for this PR to be merged?

avatar zero-24
zero-24 - comment - 17 Jun 2016

Hi @helvecio

RTC means ready to commit. So your Job is basically done. ;) Now we need a Maintainer how do a final review and merge. You can't do that for your self for understandably reason that only a fee people have merge access to the main CMS repo.

Close and comment would mean that this PR can not be merged by the maintainer so please don't so that :)

If an maintainer get the time to review the RTC PRs this here will be on the list too. Thanks for your PR!

avatar helvecio
helvecio - comment - 17 Jun 2016

Thank you for the clarification @zero-24 !

avatar brianteeman brianteeman - change - 8 Jul 2016
Milestone Added:
avatar wilsonge wilsonge - change - 21 Jul 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-07-21 20:45:22
Closed_By wilsonge
avatar roland-d roland-d - change - 22 Jul 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment