User tests: Successful: Unsuccessful:
Pull Request for improvment .
Check if travis still passes
I modified the exclusion for PEAR.Functions.ValidDefaultValue
exclude pattern due to the result of this travis build https://travis-ci.org/wojsmol/joomla-cms/jobs/137958211
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Code style |
@photodude Generic.CodeAnalysis.UselessOverridingMethod
- should I revert commit b23cc64 ?
PEAR.Functions.ValidDefaultValue
- in commit 8af941c has implemented the exclusion for a single file.
I don't think that other comit needs to be reverted, just remove Generic.CodeAnalysis.UselessOverridingMethod
from the ruleset with this PR as explained above. It was an oversite that it it didn't get removed before.
The other change for PEAR.Functions.ValidDefaultValue
is an appropreate solution for now. Long term we will need to decide if that is the most approreate solution or choose one of the other options I suggested.
@photodude done
Status | Pending | ⇒ | Ready to Commit |
RTC based on the green mark by travis Thanks ;)
Labels |
Added:
?
|
btw: what is wrong with modules/mod_articles_category/helper.php
?
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-29 10:50:44 |
Closed_By | ⇒ | wilsonge |
Milestone |
Added: |
Labels |
Removed:
?
|
Looks like there was a couple of things missed between the clean up of the phpcs 1.5.x rules and the PHPCS 2.x rules. Here is what should happen based on the decisions from the phpcs2.x development.
As for PEAR.Functions.ValidDefaultValue, that exclusion is needed. Historically we have included that sniff. Although we don't have it written out that function "Arguments with default values must be at the end of the argument list"; we do extend from the PEAR standard. I'm inclined to say that we should refactor that function or exclude the single file that's causing issues. Another option would be to implement an exclusion for
PEAR.Functions.ValidDefaultValue.NotAtEnd
if that is determined to be one of our deviations from the PEAR standard.