[#10814] - Add new version of the powered by image
- Fixed in Code Base
- 13 Jun 2016
- Medium
- Build: staging
- # 10814
- Diff
- wilsonge:image-fix
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
This is a request from the marketing team to replace the powered by image with the latest version
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-13 22:19:48 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
This file is not being distributed with the Joomla 3.6.0 update packages also, so a Joomla 3.5.1 upgraded to Joomla 3.6.0 and a fresh Joomla 3.6.0 have different files...
This will show in a myJoomla.com audit - or any tool - that compares the original file for the installed version against the md5 sum of the file on the server hard drive.
I said this would happen because the file was changed without a PR and
without any testing - sadly I was ignored
On 12 July 2016 at 21:47, Phil Taylor notifications@github.com wrote:
This file is not being distributed with the Joomla 3.6.0 update packages
also, so a Joomla 3.5.1 upgraded to Joomla 3.6.0 and a fresh Joomla 3.6.0
have different files...? —
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10814 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8RBEyQFnp4Ti3xiSVxBEOFLYVj69ks5qU_1cgaJpZM4I0yn3
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I really wish you wouldn't commit your own PR especially without any tests. IF the image had identical dimensions then it might not have had any impact on an existing site but as this image has different dimensions it does have an impact on the layout of an existing web site