Thanks, the x button is misleading

Can you test it and mark the results please

I have tested this item ✅ successfully on 95aa152

what about using am info sign (i) or question mark sign (?) icons

since you'll go to options panel, the icon i think it should be is the options icons (the same that exists in options button).

I'm open to any suggestion for the symbol displayed. As far as I can tell
it must be an html entity though
On 15 Jun 2016 9:06 a.m., "andrepereiradasilva" notifications@github.com
wrote:

since you'll go to options panel, the icon i think it should be is the
options icons (the same that exists in options button).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8VLf01zIbLio7R5r4tSg2C7CvtCFks5qL7J0gaJpZM4I0cZH
.

did you try:
<span class="icon-options"></span>

Not a fan of doing that as it would not be an accessible link

@wilsonge @rolandd can you make a decision on the htmlentity to use please

I have tested this item ✅ successfully on 95aa152

As expected.

I have tested this item ✅ successfully on 95aa152

@brianteeman I agree with Andre that we should use the same symbol as for the Options. To get this done you can remove the ⊕ and leave the string empty. In the class statement add icon-options and you will get the symbol used to go to Options. That should be good enough I think.

Will that work in Hathor?

Yes, works in Hathor as well.

Ok . Am at a 40th birthday I will fix tomorrow

Thanks

This PR has received new commits.

CC: @bertmert, @crommie, @pe7er

Updated the PR with @roland-d and @andrepereiradasilva suggestion to use the options icon as seen in this screenshot

IMHO the icon is to big, can you remove the close class?

Not that simple. The close class also gives it the position

On 26 June 2016 at 12:38, andrepereiradasilva notifications@github.com
wrote:

IMHO the icon is to big, can you remove the close clsss?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10811
https://issues.joomla.org/tracker/joomla-cms/10811.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8feAssLa4SO5bcyQYMbf8xkGu9mJks5qPmStgaJpZM4I0cZH
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I guess I could give it its own class
alert-options

?

On 26 June 2016 at 12:50, Brian Teeman brian@teeman.net wrote:

Not that simple. The close class also gives it the position

On 26 June 2016 at 12:38, andrepereiradasilva notifications@github.com
wrote:

IMHO the icon is to big, can you remove the close clsss?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10811
https://issues.joomla.org/tracker/joomla-cms/10811.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8feAssLa4SO5bcyQYMbf8xkGu9mJks5qPmStgaJpZM4I0cZH
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @bertmert, @crommie, @pe7er

I have tested this item ✅ successfully on 058362e

I have tested this item ✅ successfully on 058362e

RTC :)

@brianteeman The new icon is not in the same location as the old icon. The new icon is quite a lot close to the text. Is that on purpose?

The icon is inside the div and the div has been given a margin - I dont think it can be altered when using an icon as requested

I have no preference either way, just noticed the difference. On one hand I am thinking it is OK because it is not your regular close button. If someone wants to change it later, it can always be done. The change of icon is more important than it's location.

Thanks