Thanks for coding this, Puneet!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Puneet!

In the past, we haven't used the Issue Tracker for adding unit and system tests. Most people don't know how to run them. Also, they don't impact users since they are not part of the actual distribution. Normally, either Michael or I just commit them. (Normally we are the ones who wrote them.)

I have made the necessary changes please review and give me the feedback...

Great! Thanks for clarifying Mark! I'll create a github label for the unit tests issues so that they are easy to find.

Nice job on these tests, Puneet!

@Michael: What I do with the system tests is actually run through the
normal install process. This refreshes the database and also it tests that
the install works. I haven't gotten round to writing code to refresh the db
directly. Mark

On Wed, May 1, 2013 at 6:23 AM, Nick Savov notifications@github.com wrote:

Great! Thanks for clarifying Mark! I'll create a github label for the unit
tests issues so that they are easy to find.

Nice job on these tests, Puneet!

—
Reply to this email directly or view it on GitHub#1078 (comment)
.

Ahh, good to know. Guess I've just been spoiled by the unit test structure taking care of (most of) this automagically.

Hi, Thanks everyone, actually I have generated a new Pull Request for the same fix the link for the new pull request is,
#1087

I have fixed most of the issues which were present in the current pull request.

Closing this one, since we committed the other one. Thanks!