[#10761] - taging issue in AJAX mode with Persian, Arabic, Hebru
- Closed
- 9 Oct 2016
- Medium
- Build: master
- # 10761
Hi there,
I have seen an issue with tags. When a user wants to add a tag, after typing 3 letters no matter the user is still typing or not, Joomla automatically completes the tag if there is a word in the list width those letters.
For example, if I want to write "signature" and there is the word "sign" in the list, joomla selects "sign" and doesn't let me to type the compete word "signature" (I wrote in English for everyone to understand but in English it is ok the issue is in Arabic, Persian and Hebru).
It's an annoying issue. I tried editing libraries-> cms-> html-> formbehavior.php by placing $afterTypeDelay = $options->get('afterTypeDelay', '250000'); but it doesn't work and I couldn't find any solution.
@A-Kasaaian Can you copy-paste some of the tags that are causing the issue here? I suspect that the problem is with the UTF-8 handling so we will need some test strings to look at.
| Labels |
Added:
?
|
||
| Category | ⇒ | Multilanguage Tags |
@chrisdavenport I'm sorry for interrupting you. I tested tag fields a lot. It seems that $afterTypeDelay = $options->get('afterTypeDelay', '250000'); has solved the issue, but some previously added tags like, پرو , فیسبو have the problem yet (the web site is using Persian language). I went to tags list and found something weird. Th mentioned tags are not listed in "components -> tags". All tags in this list are working fine and also recently added tags are fin too.
@A-Kasaaian the fourth letter always the same?
it sounds like Keycode problem,
somewhere here already was opened an issue for similar problem about Cyrillic keyboard layout, cannot find ..
@Fedik @chrisdavenport I found what's the problem but I don't know how to solve it. To describe the problem, while I'm typing letters other than "و" it's working fine but when I press "و" joomla selects the word as a tag automatically. It should be something with "و" ASCII code, probably.
Sounds the same as #10741
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10761.
Yes it does sound like a keycode problem with non-latin character sets using the same keycode as the latin comma causing this problem. The report about russian #10741 seems to confirm that
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10761.
You guys know these things better than me. Why this function is set on a keycode but not an ASCII code????
Just tried to reproduce this issue, but I'm getting strange behaviour with the comma character even with pure ASCII input. I'm pretty sure this is a JavaScript problem, so I'm going to leave it to the JS experts.
Actually, I have the same bug with pure English tags.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10761.
Isn't there any solution for this issue or any suggestion?????
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10761.
Please, check the change I made. I've tested these changes in different languages and it works very well.
staging...A-Kasaaian:patch-1
I'll be glad if you you apply it to the next release.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-10-09 13:28:24 |
| Closed_By | ⇒ | brianteeman |
@brianteeman several months passed. I checked pull request status. There was a conflict, which I resolved. I know you are so busy but It may help someone, if Joomla team accept the change and merge.
@A-Kasaaian Pull Request needs 2 successfully Tests before Maintainers decide if PR is good for merge.
@franz-wohlkoenig I know. But, one year ago it passed both tests successfully, but no decision was taken.
human tests not automated tests
This time I changed my solution. I simply just replaced keyup with keypress and event.which === 188 with event.charCode === 44. It should work fine and solves all the issues with all languages because "which" compares key code what is not depend on language but "charCode" is depend on language and the character you type. Comma charCode is 44 in all languages, which are containing it.
All auto tests are passed, human test is required.
@chrisdavenport
Can you have a look?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10761.