[#10757] - Fix the response from the AJAX ACL change to be correct
- Fixed in Code Base
- 8 Jun 2016
- Medium
- Build: staging
- # 10757
- Diff
- roland-d:fix-ajax-acl-settings
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Related to #10755
Summary of Changes
This change fixes the feedback given by the AJAX response when changing a permission.
Testing Instructions
- Go to System -> Global configuration -> Permission
- Click on Super User
- Change the permission to Denied
- The response is that the permission is Denied which is not true should be Allowed (Super User)
- Click on Manager
- Change Site Login to Denied
- Click on Administrator
- Change Site Login to Allowed
- The response is that the permission is Allowed which is not true should be Conflict because the Denied of Manager overrules the Administrator setting
- Apply the patch
- Go to System -> Global configuration -> Permission
- Click on Super User
- Change the permission to Denied
- The response is that the permission is Allowed (Super User). This is correct because the Super User setting overrules this.
- Click on Manager
- Change Site Login to Denied
- Click on Administrator
- Change Site Login to Allowed
- The response is that the permission is in Conflict. This is correct because the Denied of Manager overrules the Administrator setting of Allowed
Calling @andrepereiradasilva and @infograf768 for special attention :)
| Status | New | ⇒ | Pending |
| Milestone |
Added: |
||
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | ACL |
| Milestone |
Removed: |
||
@andrepereiradasilva Again, I agree with you but the current implementation doesn't support this. My goal is to fix the problems first and then improve what we have.
ok right!
siesta time, will look later.. ;)
Just an additional comment.
Before doing
18 Change Site Login to Allowed
The administrator "Site Login" caculated permission is "Not Allowed (Locked)".
And when changed to "Allowed" we get "Conflict".
So, if i understand correctly, we have two text strings for the same thing ... that is rather confusing.
I guess this was nothing to do with this PR, but this could be better.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10757.
@andrepereiradasilva You now see the quicksand I have been playing with :)
I have tested this item
OK here. I can't believe how bad ACL has gone...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10757.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
@infograf768 At least we are fixing it :)
@andrepereiradasilva Thanks.
You are! I can't believe no one else tries.
back to siesta
| Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-08 15:39:23 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
IMHO "Conflict" is not the right word, should be "Not Allowed (parent rule)" or something like that.