Joomla! Issue Tracker | Joomla! CMS #10751

? ?

Fixed in Code Base
8 Jun 2016
Medium
Build: staging
# 10751
Diff
wilsonge:jquery-upgrade

Pending

Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details

User tests: Successful: Unsuccessful:

wilsonge
7 Jun 2016

Pull Request for Issue #10351

Summary of Changes

This succeeds @rdeutz 's PR at #10351 - it adds a generic on before validation event to allow manipulation of data to validate including the com_users PR that he mentioned earlier

Testing Instructions

Ensure there are no PHP errors in any core components

257ab40 4 Jun 2016

jQuery upgrade

a78cb88 4 Jun 2016

Fix tabs error with new jQuery version

52e749a 4 Jun 2016

Fix more instances of deprecated selectors

5c5babd 7 Jun 2016

Add new plugin event for manipulation of data validation

e29146a 7 Jun 2016

Merge branch 'staging' into jquery-upgrade

wilsonge - open - 7 Jun 2016

wilsonge - change - 7 Jun 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 7 Jun 2016

Labels

Added: ?

brianteeman - change - 8 Jun 2016

Category

⇒

Plugins

4ab70a5 8 Jun 2016

Modify since

d696bef 8 Jun 2016

Modify since

162e40f 8 Jun 2016

Add trailing comma

wilsonge - comment - 8 Jun 2016

@zero-24 fixed

wilsonge - change - 8 Jun 2016

Milestone

Added:

zero-24 - comment - 8 Jun 2016

Thanks i have just noticed that there is a issue with the tests?!

There were 6 errors:
1) JModelFormTest::testValidateReturnsFalseOnJformException
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:57
2) JModelFormTest::testValidateReturnsFalseOnJformFalse
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:101
3) JModelFormTest::testValidateModifiesTagsArray with data set #0 (array('1'), array('1'))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
4) JModelFormTest::testValidateModifiesTagsArray with data set #1 (array(array('1')), array(array('1'), '1'))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
5) JModelFormTest::testValidateModifiesTagsArray with data set #2 (array('1', array('2')), array('1', array('2')))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
6) JModelFormTest::testValidatePassesDataAndGroupToJform
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:186

rdeutz - test_item - 8 Jun 2016 - Tested successfully

rdeutz - comment - 8 Jun 2016

I have tested this item ✅ successfully on 162e40f

works as expected (with the simplify user plugin) when also applying #10350

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.}

bfd7cae 8 Jun 2016

Try fixing tests

a58aaf8 8 Jun 2016

Merge remote-tracking branch 'wilsonge/jquery-upgrade' into jquery-upgrade

joomla-cms-bot - comment - 8 Jun 2016

This PR has received new commits.

CC: @rdeutz

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.}

joomla-cms-bot - change - 8 Jun 2016

Labels

Added: ?

72737f7 8 Jun 2016

Stop the database queries

joomla-cms-bot - comment - 8 Jun 2016

This PR has received new commits.

CC: @rdeutz

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.}

wilsonge - change - 8 Jun 2016

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-06-08 21:51:06
Closed_By		⇒	wilsonge

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#10751] - New Plugin Event

Summary of Changes

Testing Instructions

Add a Comment