Feeling Lucky
?
[#10742] - Fix PHP 7 compatibility when attaching observer type of FOFUtilsObservableEvent
- Fixed in Code Base
- 9 Jun 2016
- Medium
- Build: staging
- # 10742
- Diff
- piotrmocko:patch-27
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fix PHP 7 compatibility when attaching observer type of FOFUtilsObservableEvent
Read this issue akeeba/fof#593
and this commit 791f561
Testing Instructions
Just review the code. When you will attach more then one observer type of FOFUtilsObservableEvent with the same event name (e.g. onAfterGetItem) then only the first observer will be fired twice.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | External Library |
piotrmocko
- comment
- 9 Jun 2016
I have changed it to match akeeba/fof@121eff4
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-09 06:54:03 |
| Closed_By | ⇒ | piotrmocko |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-06-09 06:54:03 | ⇒ | |
| Closed_By | piotrmocko | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-09 09:40:05 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 9 Jun 2016
Merged :) Thanks!
| Milestone |
Added: |
||
Can we please stick to what Nic is doing in FOF please :) From the issue you linked to Nic put the end() function higher up in the function (akeeba/fof@121eff4)