[#10735] - [com_redirect] Improve disabled collect url in redirect plugin message
- Fixed in Code Base
- 7 Jun 2016
- Medium
- Build: staging
- # 10735
- Diff
- andrepereiradasilva:redirect-collect-message
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Following PR #10688 that improve the link in com_redirect when the redirect plugin is disabled, this PR does similar change to the collect URL disable message.
Some other changes:
- The Collect URL warning is now a notice
- When redirect plugin was enabled AND collect URL option is enabled a notice is displayed. This notice was removed as it's not consistent with the other component list views.
Testing Instructions
- USe latest staging
- Go to Extensions -> Plugins -> Redirect (System) enable the plugin and disable collect urls
- Go to Components -> Redirect, you will see the following message
- Apply patch
- Go to Components -> Redirect, you will see the following message
- Now enable the collect URL in the redirect plugin, you'll see no message
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
thanks, done
| Category | ⇒ | Components Language & Strings |
| Labels | |||
I have tested this item
> [05-Jun-2016 23:27:29 Europe/London] PHP Fatal error: Call to undefined method RedirectHelper::getRedirectPluginId() in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_redirect/views/links/view.html.php on line 58
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10735.
oops i might not be on current staging
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10735.
I have tested this item
Yeah - i wasnt on latest staging - all good
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10735.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10735.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-07 19:44:26 |
| Closed_By | ⇒ | wilsonge |
Merged - thanks :)
| Labels |
Removed:
?
|
||
@andrepereiradasilva See https://joomla.github.io/coding-standards/?coding-standards/chapters/php.md elseif should be one word.