[#10728] - Fix#10724. "List of all tags" menu item incompatible with caching
- Fixed in Code Base
- 25 Jun 2016
- Medium
- Build: staging
- # 10728
- Diff
- bertmert:patch-2
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #10724
Summary of Changes
Set default value $cachable = false in method display() like in all other core component controllers.
Testing Instructions
by @Giuse69 (corrected by me)
Create a tag A with subtags A1, A2.
Create a tag B with subtags B1, B2.
Create a menu item MENU_A of type "list of all tags" for A to show all tags below A by setting Parent Tag to A.
Create another menu item MENU_B of type "list of all tags" for B to show all tags below B by setting Parent Tag to B.
Enable caching.
Go to frontend and click on MENU_A: you get the list of subtags of A.
Now click on MENU_B. You'll see content of MENU_A (subtags of A, not subtags of B).
Apply patch.
Test again.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
brianteeman
- | Category | ⇒ | Cache Tags |
| Rel_Number | 0 | ⇒ | 10724 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on testing.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-25 13:26:31 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
Thanks everybody
I have tested this item✅ successfully on 74ba56d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10728.