[#10720] - Render the sidebar when it is not empty
- Fixed in Code Base
- 15 Jun 2016
- Medium
- Build: staging
- # 10720
- Diff
- Digital-Peak:sidebar
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
When a plugin adds some sidebar entries for com_modules, then render it.
Testing Instructions
- Install DPFields from https://joomla.digital-peak.com/download/dpfields
- In the back end go to the Extensions -> Modules
Expected result
You should see on the left side a list of links (Modules, Fields, Field Categories). After DPFields is uninstalled, the view Extensions -> Modules should be shown without a sidebar.
Actual Result
The sidebar is not shown.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I tested it and it showed then the sidebar with an empty list.
*sigh* I guess this is one of those views where it might be an optional thing.
Means?
Just as you pointed out, the sidebar here can be empty. On most other views that have the sidebar conditional, it's usually not unless someone used a malicious plugin to remove the component's defined sidebar so that conditional is just bloated logic.
I have tested this item
works as described
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10720.
| Category | ⇒ | Administration |
I have tested this item
(side note not related to this PR. uninstalling dpfields package gives error - i expected it to remove all of dpfields)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10720.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-15 23:23:17 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
How about just always render it and avoid conditionals like https://github.com/Digital-Peak/joomla-cms/blob/98aca2d283ae91c39414207fbc477b46b130e11b/administrator/components/com_modules/views/modules/tmpl/default.php#L29-L36 in the layouts.