Joomla! Issue Tracker | Joomla! CMS #10713 - [plg_search_tags] Search results now don't include unpublished, archived or trashed tags

Fixed in Code Base
15 Jun 2016
Medium
Build: staging
# 10713
Diff
EmilMassey:tags_plugin

Pending

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

EmilMassey
2 Jun 2016

Pull Request for Issue #10712 .

Summary of Changes

Select only published tags from the database by adding $query->where('a.published = 1');.

Testing Instructions

Make sure Search - Tags plugin is enabled
Create a tag
Unpublish, archive or trash it
Type a tag name in a mod_search module
Only published tags should be listed.

Votes

# of Users Experiencing Issue

2/2

Average Importance Score

4.00

742f52b 2 Jun 2016

Merge pull request #1 from joomla/staging

c0b829b 2 Jun 2016

Select only published tags from database

EmilMassey - open - 2 Jun 2016

EmilMassey - change - 2 Jun 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 2 Jun 2016

Labels

Added: ?

brianteeman - change - 2 Jun 2016

Category

⇒

Plugins Tags

infograf768 - comment - 3 Jun 2016

Looking at code, I think you should separate the query for published, and leave alone the code with if ($app->isSite() && JLanguageMultilang::isEnabled()) as this is done in the other search plugins.
I.e. should be:

        $query->where('a.published = 1');

        if ($app->isSite() && JLanguageMultilang::isEnabled())
        {
            $tag = JFactory::getLanguage()->getTag();
            $query->where('a.language in (' . $db->quote($tag) . ',' . $db->quote('*') . ')');
        }

hardiktasol - test_item - 3 Jun 2016 - Tested successfully

hardiktasol - comment - 3 Jun 2016

I have tested this item ✅ successfully on c0b829b

I have tested in Joomla 3.5.1 and patch works perfectly.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

gunjanpatel - test_item - 7 Jun 2016 - Tested successfully

gunjanpatel - comment - 7 Jun 2016

I have tested this item ✅ successfully on c0b829b

It works perfect after applying path.
It has two successful tests, but as per @infograf768 suggestion, I agree that $query->where('a.published = 1'); should be outside of the condition. Also, I would like to suggest below code to use quoteName.

$query->where($db->qn('a.published') . ' = 1');

Thanks for fixes.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

brianteeman - change - 7 Jun 2016

Status

Pending

⇒

Ready to Commit

brianteeman - comment - 7 Jun 2016

rtc

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

joomla-cms-bot - change - 7 Jun 2016

Labels

Added: ?

brianteeman - change - 7 Jun 2016

Milestone

Added:

wojsmol - comment - 7 Jun 2016

@brianteeman Please remove RTC, see comments by @infograf768 and @gunjanpatel .

brianteeman - change - 7 Jun 2016

Labels

Removed: ?

brianteeman - comment - 7 Jun 2016

Done

joomla-cms-bot - change - 7 Jun 2016

Labels

Added: ?

brianteeman - change - 7 Jun 2016

Status	Ready to Commit	⇒	Pending
Labels

brianteeman - comment - 7 Jun 2016

Back to pending

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

joomla-cms-bot - change - 7 Jun 2016

Labels

Removed: ?

infograf768 - comment - 7 Jun 2016

@EmilMassey

Please update your PR

db7e77e 7 Jun 2016

Move where clause outside isSite condition, quote name

joomla-cms-bot - comment - 7 Jun 2016

This PR has received new commits.

CC: @gunjanpatel, @hardiktasol

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

wilsonge - change - 8 Jun 2016

Milestone

Removed:

gunjanpatel - test_item - 10 Jun 2016 - Tested successfully

gunjanpatel - comment - 10 Jun 2016

I have tested this item ✅ successfully on db7e77e

Tested successfully.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

brianteeman - comment - 10 Jun 2016

As the previously tested PR has been updated and confirmed by @gunjanpatel I am setting this back to RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

brianteeman - change - 10 Jun 2016

Status

Pending

⇒

Ready to Commit

brianteeman - comment - 10 Jun 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713.}

joomla-cms-bot - change - 10 Jun 2016

Labels

Added: ?

brianteeman - change - 10 Jun 2016

Milestone

Added:

EmilMassey - comment - 11 Jun 2016

Thank you @infograf768, @gunjanpatel for your suggestions.

wilsonge - change - 15 Jun 2016

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-06-15 22:58:11
Closed_By		⇒	wilsonge

wilsonge - close - 15 Jun 2016

wilsonge - merge - 15 Jun 2016

joomla-cms-bot - close - 15 Jun 2016

wilsonge - reference | 1a026b9 - 15 Jun 16

wilsonge - merge - 15 Jun 2016

wilsonge - close - 15 Jun 2016

joomla-cms-bot - change - 15 Jun 2016

Labels

Removed: ?

wilsonge - comment - 15 Jun 2016

Merged :) Thanks very much!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#10713] - [plg_search_tags] Search results now don't include unpublished, archived or trashed tags

Summary of Changes

Testing Instructions

Votes

Add a Comment