? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
1 Jun 2016

Pull Request for Issue #10604

Summary of Changes

change extensions to packages

Testing Instructions

  • set maximum upload file size to less than 8MB
  • see the message in the updater
  • see the message in the extension manger
avatar zero-24 zero-24 - open - 1 Jun 2016
avatar zero-24 zero-24 - change - 1 Jun 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2016
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 1 Jun 2016

@brianteeman is the language change acceptable? As the same string is used in both places.

avatar brianteeman
brianteeman - comment - 1 Jun 2016

Not really. Will answer in full when I get home.
On 1 Jun 2016 1:57 pm, "zero-24" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman is the language change
acceptable? As the same string is used in both places.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10707 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8cnwbwif8WzZDVOk2zwo8vhS97m3ks5qHYGygaJpZM4IrgIV
.

avatar brianteeman
brianteeman - comment - 1 Jun 2016

Thats what happens when I read a PR on my phone. Your string is fine by me. The one that is not good is https://github.com/zero-24/joomla-cms/blob/280b8348266ed7b25879f3b6d84dcc2815b78d76/administrator/language/en-GB/en-GB.com_installer.ini#L170 but thats for another PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10707.

avatar brianteeman brianteeman - test_item - 1 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 Jun 2016

I have tested this item ✅ successfully on 280b834


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10707.

avatar brianteeman brianteeman - change - 1 Jun 2016
Labels
avatar brianteeman brianteeman - change - 1 Jun 2016
Category ⇒ Language & Strings
avatar andrepereiradasilva andrepereiradasilva - test_item - 1 Jun 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 1 Jun 2016

I have tested this item ✅ successfully on 280b834


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10707.

avatar zero-24 zero-24 - change - 1 Jun 2016
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 2 Jun 2016

RTC Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10707.

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 Jun 2016
Milestone Added:
avatar roland-d roland-d - change - 4 Jun 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-06-04 10:19:03
Closed_By ⇒ roland-d
avatar roland-d
roland-d - comment - 4 Jun 2016

Thanks everybody

avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment