Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10695] - [com_modules] positions view: client_id selector naming

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
31 May 2016

Summary of Changes

The client_id seletor is named client_id, not filter.client_id.. This was uniformized in 3.6.0 across all modules, cache, templates and languages views (the ones that have the client_id selector).

One view remain: the positions view in com_modules. I think this view is unused in the core but still should be changed. So, this PR changes it.

Testing Instructions

  • Apply patch

  • Test /administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component&client_id=0

(should show the site template positions)

  • Test /administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component&client_id=1

(should show the admin template positions)

  • Test /administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component

(should show the admin template positions, since it was the last one used)

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00
avatar andrepereiradasilva andrepereiradasilva - open - 31 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 31 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 31 May 2016
The description was changed
avatar brianteeman brianteeman - change - 31 May 2016
Category ⇒ Code style Components
avatar JoomliC
JoomliC - comment - 31 May 2016

This modal is used in Hathor ;-)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695.

avatar brianteeman brianteeman - change - 31 May 2016
Category Code style Components ⇒ Code style Components Templates (admin)
avatar andrepereiradasilva
andrepereiradasilva - comment - 31 May 2016

lol always hathor ...

avatar brianteeman brianteeman - test_item - 10 Jun 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Jun 2016

I have tested this item ✅ successfully on 62fb58f

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695.

avatar chmst
chmst - comment - 13 Jun 2016

I've tested this successfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695.

avatar chmst chmst - test_item - 13 Jun 2016 - Tested successfully
avatar chmst
chmst - comment - 13 Jun 2016

I have tested this item ✅ successfully on 62fb58f

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695.

avatar brianteeman brianteeman - change - 13 Jun 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Jun 2016

Rtc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Jun 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-06-15 23:20:08
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 15 Jun 2016
avatar wilsonge wilsonge - merge - 15 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 15 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment