Feeling Lucky
?
[#10692] - Removed superfluous logic from JFormRuleEmail
- Closed
- 20 Aug 2017
- Medium
- Build: staging
- # 10692
- Diff
- superhaggis:remove-duplicate-email-pattern-logic
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
The email address pattern property is set by default, and the conditional code makes no changes to it so can therefore be removed. In addition, the $tld variable can be removed as it is no longer required.
Testing Instructions
Run tests as normal. Tests don't need to be modified as only redundant logic was removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
brianteeman
- comment
- 20 Aug 2017
It has been over a year since this was submitted and with no test instructions it has had no tests and is now conflicting. I am closing this at this time. It can always be reopened if the conflicts are fixed AND test instructions are provided
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-20 11:59:26 |
| Closed_By | ⇒ | brianteeman |
@superhaggis can you please explain how to test?