Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10667] - [FIX 3.6.0-alpha] Do not close edit modal when escape key is pressed (Thanks @andrepereiradasilva !)

? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
29 May 2016

Pull Request for Issue comment #10654 (comment).
cc/ @andrepereiradasilva

Summary of Changes

  • In already merged new edit modals, it was fixed to not allow closing of an edit modal on click (needed behavior for a clean item edit closing), to allow closing only on close, Save & Close and Save buttons, but it was still possible to close with escape key.
  • This PR disable the possibility to close the edit modal when escape key is pressed
  • A few ordering changes of modal params, to be consistend with the modal main jlayout

Testing Instructions

To be tested on 3.6.0-alpha or latest staging!
This could be tested for those modals (test that you can't close modal with escape key):

  • Menus > Manage : button to edit modules and Add a module for this menu
  • in all menu item edition : go to tab "Modules Assignment" and click on one of the modules name to open Edit modal.
  • Menus > Menu > Menu item with item type Single Article Select article, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Category Blog Select category, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Single Contact Select contact, save and then click on Edit button to open Edit modal
  • Menus > Menu > Menu item with item type Single Newsfeed Select newsfeed, save and then click on Edit button to open Edit modal
  • article, category, newsfeed, contact in associations tab for each item should have the same behavior.
avatar JoomliC JoomliC - open - 29 May 2016
avatar JoomliC JoomliC - change - 29 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 29 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 29 May 2016

I have tested this item ✅ successfully on a1d1b06

Works fine! thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

avatar BurtNL BurtNL - test_item - 29 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 29 May 2016

I have tested this item ✅ successfully on a1d1b06

Works as described

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

avatar brianteeman brianteeman - change - 29 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman brianteeman - change - 29 May 2016
Category ⇒ Administration
avatar brianteeman
brianteeman - comment - 29 May 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10667.

avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 29 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 30 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-30 22:50:03
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 30 May 2016
avatar wilsonge wilsonge - merge - 30 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 30 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment