User tests: Successful: Unsuccessful:
Code style changes for com_content
code review
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Code style |
ok please make the changes i identified and for me is ok.
I have tested this item
This PR has received new commits.
I have tested this item
This PR has received new commits.
I have tested this item
This PR has received new commits.
I have tested this item
@zero-24 @JoomliC Can you test this please and then we can get it merged
@brianteeman For changes done, it's almost good for me. (added 2 notes)
Additionnal comments :
I would say: fix branch conflicts and at least 1 note for label/desc order in xml and it's ok for me! ;-)
Category | Code style | ⇒ | Repository Unit Tests Administration Components SQL Postgresql MS SQL Code style |
Labels |
Added:
?
|
That rebase isnt correct unless you really did edit 800+ files ;)
@brianteeman last good commit is d1796dc
@JoomliC @andrepereiradasilva Plese do a final check.
@brianteeman Please remove Unit/System Tests label.
Category | Code style Repository Unit Tests Administration Components SQL Postgresql MS SQL | ⇒ | Administration Components Front End Code style |
Labels |
Removed:
?
|
I've removed the label
@JoomliC @andrepereiradasilva This branch contains conflicts again, check it out after work.
Category | Code style Administration Components Front End | ⇒ | Repository Administration Components Language & Strings Templates (admin) Front End Code style |
Labels |
Added:
?
|
@wojmol did a full review of changes, and it's ok for me!
Just the 3 mentionned by note lines to be removed ;-)
@JoomliC conflict markers removed in 289975c
@brianteeman Pleaseremove Language Change label - added by @joomla-cms-bot as a effrct of bad rebase.
I have tested this item
Code review + Patch applied
All seems good!
rebase after recent changes
Is this outdated?
@Quy Tgis is very oudated especially after recent PR's from @brianteeman.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 15:48:10 |
Closed_By | ⇒ | wojsmol |
Category | Code style Administration Components Front End Repository Language & Strings Templates (admin) | ⇒ | Administration com_content Front End Code style Components |
When I have several free hours, I will go over com_content again and create a new PR if needed.
@wojsmol I only checked config.xml, and already 6 errors found...
Could you please do a new checking of all yours changes in this PR ? (i know it's time, but it could save time too on review ;-) )
One question: you started with plugins, then modules, and now components, but not all modules/plugins are reviewed (just did mod_multilangstatus yesterday in the same time of another purpose), so, is there a reason for that ? (code style review is a long and not funny job, but good to be done, but maybe i could help later when i will have finished some other work on modals) ;-) ).
Note: could you not work on com_templates for now, as i have started many changes in many files, and so, i can do the code style review for this component in the same time)