? ? Failure

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
28 May 2016

Summary of Changes

Reorganised the menu items under the extension manager top level menu item. As seen in the past few release we are no longer supporting Joomla core update via extensions manager, that is a good move. Having a good explanation from @brianteeman and @mbabker I was convinced well that these two need to operate independently with no internal handovers.

However, I can understand the annoyance caused to Brian and Michael explaining this to everyone separately over and again. I suggest to make some visual change that calls for the users' action.

With this reorganisation, people would feel that there is some change right there. Investing little they would be able to see both options alongside and tend more towards using appropriate option rather than assuming "I did it before, why not now!".

Testing Instructions

  • New testers only: Please follow the testing instructions at Testing Joomla! patches
  • Every link should open the correct page.
  • Changing permissions on 'com_joomlaupdate', 'com_postinstall' and 'com_installer' should hide the respective menu items correctly.

PS: Asking for password on Joomla Update seems unnecessary and annoying as well. If we really want to be sure it could be just a confirm checkbox or a button. Irrelevant here.

avatar izharaazmi izharaazmi - open - 28 May 2016
avatar izharaazmi izharaazmi - change - 28 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Added: ? ?
avatar izharaazmi
izharaazmi - comment - 28 May 2016

Old menu looked like:

image

image

With this PR they look like:

image
image
image

avatar brianteeman
brianteeman - comment - 28 May 2016

I much prefer that we don't continue with hard coding the admin menu and
finally have a real admin menu manager that is configurable

avatar izharaazmi
izharaazmi - comment - 28 May 2016

That would be better. J3.6 itself or leave it for 3.7!

avatar brianteeman
brianteeman - comment - 28 May 2016

Too late for 3.6 please see #5492

avatar izharaazmi
izharaazmi - comment - 28 May 2016

Wow! That's my Sunday treat ? I'll surely read all that tomorrow and make up my mind around.

Well, in that case we may consider this small change for now. Right?

avatar zafarnayab zafarnayab - test_item - 15 Jun 2016 - Tested successfully
avatar zafarnayab
zafarnayab - comment - 15 Jun 2016

I have tested this item successfully on a2bfff3

I've tested this .
It works Successfully...
All link works Perfectly same as it works before Patched.

While revoking Permission on 'com_joomlaupdate', 'com_postinstall' and 'com_installer' it hidden for the respective User.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar wilsonge wilsonge - change - 18 Jun 2016
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Jun 2016

This PR has received new commits.

CC: @zafarnayab


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar izharaazmi
izharaazmi - comment - 19 Jun 2016

Can we remove label "Language Change" as this no longer requires one!

avatar brianteeman
brianteeman - comment - 19 Jun 2016

Removed as requested (note it is still too late for 3.6)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar brianteeman brianteeman - change - 19 Jun 2016
Labels Removed: ?
avatar izharaazmi
izharaazmi - comment - 19 Jun 2016

Well, if protocols says I must obey.

May I ask under which specific reason this is late, coz IMO, this is just a reorganisation of existing menu items only. No additions, no removal of anything at all and no b/c break, no new feature. Just visual change.

I assumed the language freeze was the issue, hence I modified. I must be missing something, please enlighten me.

About the backend menu manager (i had a look at #5492), it sounds great to me and that I'd gladly work on if suggested/assigned to. And that I think is too late for now and should be considered only for J3.7.

avatar brianteeman
brianteeman - comment - 19 Jun 2016

re #5492 I really want to see that happen so any help i can give you I will

re this PR my understanding that as we are in beta stage then we are
"feature complete" see
https://developer.joomla.org/news/586-joomla-development-strategy.html

Maybe @wilsonge can expand on that

On 19 June 2016 at 11:39, Izhar Aazmi notifications@github.com wrote:

Well, if protocols says I must obey.

May I ask under which specific reason this is late, coz IMO, this is just
a reorganisation of existing menu items only. No additions, no removal
of anything at all and no b/c break, no new feature. Just visual change.

I assumed the language freeze was the issue, hence I modified. I must me
missing something, please enlighten me.

About the backend menu manager (i had a look at #5492
#5492), it sounds great to
me and that I'd gladly work if suggested/assigned to. And that I think is
too late for now and should be considered only for J3.7.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10657 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8U0mxwppI0y72Zxi_HSchvwxVomJks5qNRxvgaJpZM4IpGX7
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar izharaazmi
izharaazmi - comment - 19 Jun 2016

IMO, this is not even a feature, however if you think so.
This could be really helpful to people messing with the new Joomla update method vs extension installer.

For #5492. I'll soon get into a strategy as well as some programming based on the discussion there plus my understanding. I'll get back to you as and when needed.

avatar bertmert bertmert - test_item - 19 Jun 2016 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 19 Jun 2016

I have tested this item ? unsuccessfully on 1b0008c

Firefox. Staging staging 2016-06-16.
Applied patch. Clicked on Manage. Clicked on System. First level closes. Second level remains open.

19-06-_2016_15-11-40

avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Jun 2016

This PR has received new commits.

CC: @bertmert, @zafarnayab


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar bertmert bertmert - test_item - 19 Jun 2016 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 19 Jun 2016

I have tested this item ? unsuccessfully on 967145d

Problems with mobile menu.

Resize window or use mobile device to see mobile menu.

Tip Extensions. That's OK because you have the sidebar menu in next view.
19-06-_2016_17-12-04

Tip System. That's not OK because this is a "dead end street".

19-06-_2016_17-16-24

avatar izharaazmi
izharaazmi - comment - 19 Jun 2016

@bertmert This PR does not add anything different that is not already in
the cms.
Does it work as expected before this patch? Waiting for your images and
description.

Thanks.

avatar bertmert
bertmert - comment - 19 Jun 2016

See edits above.

avatar brianteeman brianteeman - test_item - 19 Jun 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 19 Jun 2016

I have tested this item ? unsuccessfully on 967145d

I confirm the findings of @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar brianteeman brianteeman - change - 24 Jun 2016
Category Administration UI/UX
avatar NeerajTasol NeerajTasol - test_item - 12 Jul 2016 - Tested successfully
avatar NeerajTasol
NeerajTasol - comment - 12 Jul 2016

I have tested this item successfully on 967145d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar JamalTailored JamalTailored - test_item - 12 Jul 2016 - Tested successfully
avatar JamalTailored
JamalTailored - comment - 12 Jul 2016

I have tested this item successfully on 967145d

Tested using joomla staging branch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Category Administration UI/UX Administration Modules UI/UX
avatar izharaazmi
izharaazmi - comment - 29 Jul 2016

Made some changes against reported issue in test failures above. Please test again.

image

image

avatar brianteeman
brianteeman - comment - 29 Jul 2016

What about the hathor template? It doesnt always have to be identical but if you are moving a menu item from components to extensions in Isis then the same should be done in hathor


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10657.

avatar izharaazmi
izharaazmi - comment - 29 Jul 2016

Ok. I'll do it in couple of hours.

avatar izharaazmi
izharaazmi - comment - 29 Jul 2016

@brianteeman While implementing this in hathor override, I notice the following differences in hathor vs isis. Which looks like due to out of sync changes (like I did an hour ago).

isis hathor
System menu item (containing its items) as first top level menu A separate top level menu item settings at end
Menu > All Menu Items present Menu > All Menu Items missing
Template > Style, Template present Template > Style, Template missing

Should I update those too?
Doing so will make the override unnecessary (identical to default) so is it okay to rather remove the override?

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2016
Category Administration UI/UX Modules Administration Modules Templates (admin) UI/UX
avatar izharaazmi
izharaazmi - comment - 18 Oct 2016

@brianteeman I am now up and regular working for the backend menu manager as discussed earlier and I'm already half way through. I'd submit the code here as soon as I am ready with a working prototype/alpha. I am not sure if we'd make it to 3.7 but I really wish we do.

I'd need some help and guidelines. If you can spare some time please be in touch.

For now I want your ideas for menutypes (actually menu item types). For front-end they are loaded from component views and metadata xml etc. What should be the best way for backend?

avatar izharaazmi
izharaazmi - comment - 18 Oct 2016

Can we also have some testers for this PR, until we are ready with that better solution.

avatar brianteeman
brianteeman - comment - 18 Oct 2016

For this PR I would really try to hold off on it and see if we can get the
real one done ;) Even if it is not ready for 3.7 I dont really think we
should be changing things twice

For the real PR - great stuff - maybe if you create a github repo for it we
can discuss it there

On 18 October 2016 at 15:50, Izhar Aazmi notifications@github.com wrote:

Can we also have some testers for this PR, until we are ready with that
better solution.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10657 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dtdaBLK_wjYEGpxlD3SkFBZOTWOks5q1NyfgaJpZM4IpGX7
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar izharaazmi
izharaazmi - comment - 18 Oct 2016

Thanks @brianteeman for such quick response. You can see ongoing work here izharaazmi#1

avatar izharaazmi izharaazmi - reference | 125df21 - 17 Nov 16
avatar izharaazmi izharaazmi - reference | 40f913a - 17 Nov 16
avatar rdeutz rdeutz - reference | 4e156fa - 17 Jan 17
avatar rdeutz rdeutz - reference | 97300cf - 17 Jan 17
avatar dgt41 dgt41 - reference | - 18 Jan 17
avatar dneukirchen dneukirchen - reference | e808a25 - 12 Feb 17
avatar izharaazmi izharaazmi - change - 11 Apr 2017
The description was changed
avatar joomla-cms-bot joomla-cms-bot - change - 11 Apr 2017
Category Administration UI/UX Modules Templates (admin) Modules Administration UI/UX
avatar izharaazmi
izharaazmi - comment - 11 Apr 2017

May I ask for this now please! :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

@izharaazmi you mean for tests?

avatar izharaazmi
izharaazmi - comment - 11 Apr 2017

Yes

avatar infograf768
infograf768 - comment - 11 Apr 2017

A bit too late imho for 3.7.0. Has to be considered for 3.7.1 or 3.8

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Apr 2017

I have tested this item successfully on 740cfec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

avatar izharaazmi izharaazmi - change - 12 Apr 2017
The description was changed
avatar izharaazmi izharaazmi - edited - 12 Apr 2017
avatar Gavakshi Gavakshi - test_item - 12 Apr 2017 - Tested successfully
avatar Gavakshi
Gavakshi - comment - 12 Apr 2017

I have tested this item successfully on 740cfec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

avatar jeckodevelopment jeckodevelopment - change - 12 Apr 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 12 Apr 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

avatar brianteeman
brianteeman - comment - 12 Apr 2017

This is a big change in the UI and should not be just set to RTC based on two tests that it works

avatar rdeutz rdeutz - change - 12 Apr 2017
Milestone Added:
avatar mbabker
mbabker - comment - 21 May 2017

My first thought here is let's do this in 4.0 and leave potentially major workflow related changes alone in 3.x in favor of stability at this point (and moving menu items is a major workflow change).

avatar brianteeman
brianteeman - comment - 22 May 2017

I agree

avatar tonypartridge
tonypartridge - comment - 29 Jun 2017

Agreed this should be moved to V4. Users won't be pleased with this change in 3.x since it's quite a workflow change.

But I think it's a great idea.

avatar mbabker mbabker - change - 1 Jul 2017
Milestone Added:
avatar mbabker mbabker - change - 1 Jul 2017
Milestone Removed:
avatar mbabker
mbabker - comment - 1 Jul 2017

Moved to 4.0 milestone for reasons stated above.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2017
Title
Reorganise administrator menu items - extensions manager
[4.0] Reorganise administrator menu items - extensions manager
avatar joomla-cms-bot joomla-cms-bot - edited - 27 Oct 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Oct 2017

please reassign Milestone 4.0, thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Oct 2017

please reassign Milestone 4.0, thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10657.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Oct 2017

@izharaazmi can you please resolve conflicting Files?

avatar brianteeman
brianteeman - comment - 30 Oct 2017

I would wait for the results of the UX team research into the menus

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jan 2018
Build staging 4.0-dev
avatar roland-d
roland-d - comment - 22 Jul 2018

Are we ready to move on this?

avatar brianteeman
brianteeman - comment - 22 Jul 2018

Well the template team still havent completed the menu and have arbitrarily reassigned the menus etc so I guess not

avatar wilsonge
wilsonge - comment - 1 Aug 2018

Now we have the configurable admin menu and a different structure in J4 I'm going to close this for now (it totally conflicts anyhow with the xml structure for admin menus - so it would need to be completely redone to test anyhow). We can create a new version if people still feel this is a good idea later on.

avatar wilsonge wilsonge - change - 1 Aug 2018
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2018-08-01 13:02:54
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Aug 2018

Add a Comment

Login with GitHub to post a comment