? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
28 May 2016

To be tested on 3.6.0-alpha or latest Staging (needs #10388 )

Summary of Changes

  • Add viewport dimensions to modal multilanguage status (modal width: 80vw, modal body height: 70vh)
  • Code Style cc/ @wojsmol @andrepereiradasilva
  • Update version number to 3.6.0 (But, should this be done for core extensions, as none are updated ?... cc/ @wilsonge )

Testing Instructions

  • Enable Admin module Multilanguage status
  • Click on footer "Multilingual Status" button (bottom left of admin)
  • Check modal dimensions

Before Patch
capture d ecran 2016-05-28 a 13 45 45

After Patch
capture d ecran 2016-05-28 a 13 52 08

avatar JoomliC JoomliC - open - 28 May 2016
avatar JoomliC JoomliC - change - 28 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 28 May 2016
Category Modules
avatar infograf768 infograf768 - test_item - 28 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 28 May 2016

I have tested this item successfully on 2e90abe


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

Update version number to 3.6.0 (But, should this be done for core extensions, as none are updated ?... cc/ @wilsonge )

if need to automate we could change the bump.php to also do that change in minor versions for us.

avatar mbabker
mbabker - comment - 28 May 2016

The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it. But IMO it's not a big deal unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it.

with some lines of code we can have bump do all those changes for us. so yeah i thinks is always better to have this changes in bump and with that avoid "human" error.

unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.

we never now when that will ressurect ????

avatar infograf768
infograf768 - comment - 28 May 2016

In the mean while, I guess we can RTC this. Needs another test.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

ups right, forgot, will test

avatar joomla-cms-bot
joomla-cms-bot - comment - 28 May 2016

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar JoomliC
JoomliC - comment - 28 May 2016

The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it. But IMO it's not a big deal unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.

Thanks! ????
I would go for it, as IMO, it could be useful for not-developer user to know while checking extensions in manager, to know the version as well as date of each core extensions... (currently, seems weird to see extensions with version 3.0.0, and date July 2006, as if those extensions were never updated).
@andrepereiradasilva yes, a think maybe possible, and could be nice if changes for an extension, the version and creation date to be updated as well... Don't know yet if easy to manage... but let's give it a try later! (i've revert to 3.0.0 this PR for now, to be consistent with other extensions for 3.6.0).

@infograf768 I've updated the PR with @andrepereiradasilva suggestion to simplify url and footer, so need to be tested again ;-)

Thanks everybody!

avatar JoomliC
JoomliC - comment - 28 May 2016

@andrepereiradasilva I'm working on bump.php for core extensions, and seems not so difficult ;-)

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

@JoomliC tested with success.

Just one detail, normally the modals with only close button can be also closed if you click outside the modal (in the darked area) or press Escape. TIn this one you can't click outside the modal (in the darked area) to close the modal.

Shall i mark as success or will you change this?

avatar JoomliC
JoomliC - comment - 28 May 2016

@andrepereiradasilva In fact, it was like this before, but i agree that it make sense to allow it here ;-)
So updated!

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

BTW did you notice you can use Escape in the edit modals to close the modal?

avatar joomla-cms-bot
joomla-cms-bot - comment - 28 May 2016

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar andrepereiradasilva andrepereiradasilva - test_item - 28 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 28 May 2016

I have tested this item successfully on b5ac4e1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar JoomliC
JoomliC - comment - 28 May 2016

BTW did you notice you can use Escape in the edit modals to close the modal?

Nope... Not an issue here for this PR, but tomorrow, will do another PR for all edit modals already merged to disable escape with keyboard ;-) (thanks for this found!)

avatar infograf768 infograf768 - test_item - 30 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 30 May 2016

I have tested this item successfully on b5ac4e1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar infograf768 infograf768 - change - 30 May 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 30 May 2016

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.

avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 30 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-30 22:58:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2016
avatar wilsonge wilsonge - merge - 30 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 30 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment