User tests: Successful: Unsuccessful:
To be tested on 3.6.0-alpha or latest Staging (needs #10388 )
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Category | ⇒ | Modules |
The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it. But IMO it's not a big deal unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.
The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it.
with some lines of code we can have bump do all those changes for us. so yeah i thinks is always better to have this changes in bump and with that avoid "human" error.
unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.
we never now when that will ressurect
In the mean while, I guess we can RTC this. Needs another test.
ups right, forgot, will test
This PR has received new commits.
CC: @infograf768
The extension version numbers are almost never changed, right or wrong. If you want to put it in the bump script, have at it. But IMO it's not a big deal unless you're trying to modularize the core extensions, and it seems that effort has been abandoned.
Thanks!
I would go for it, as IMO, it could be useful for not-developer user to know while checking extensions in manager, to know the version as well as date of each core extensions... (currently, seems weird to see extensions with version 3.0.0, and date July 2006, as if those extensions were never updated).
@andrepereiradasilva yes, a think maybe possible, and could be nice if changes for an extension, the version and creation date to be updated as well... Don't know yet if easy to manage... but let's give it a try later! (i've revert to 3.0.0 this PR for now, to be consistent with other extensions for 3.6.0).
@infograf768 I've updated the PR with @andrepereiradasilva suggestion to simplify url and footer, so need to be tested again ;-)
Thanks everybody!
@andrepereiradasilva I'm working on bump.php for core extensions, and seems not so difficult ;-)
@JoomliC tested with success.
Just one detail, normally the modals with only close button can be also closed if you click outside the modal (in the darked area) or press Escape. TIn this one you can't click outside the modal (in the darked area) to close the modal.
Shall i mark as success or will you change this?
@andrepereiradasilva In fact, it was like this before, but i agree that it make sense to allow it here ;-)
So updated!
BTW did you notice you can use Escape in the edit modals to close the modal?
This PR has received new commits.
CC: @infograf768
I have tested this item
BTW did you notice you can use Escape in the edit modals to close the modal?
Nope... Not an issue here for this PR, but tomorrow, will do another PR for all edit modals already merged to disable escape with keyboard ;-) (thanks for this found!)
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
Labels |
Added:
?
|
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-30 22:58:02 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
I have tested this item✅ successfully on 2e90abe
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10654.