Failure

User tests: Successful: Unsuccessful:

avatar fastslack
fastslack
27 Apr 2013

With this patch, if we create a new editor using JForm we can to set the mode (Simple = 0 , Advance = 1 , Extended = 2) using the JForm xml file

avatar fastslack fastslack - open - 27 Apr 2013
avatar javigomez
javigomez - comment - 27 Apr 2013

Will be this valid for all editors or just for TinyMCE?

avatar fastslack
fastslack - comment - 28 Apr 2013

I tryed it only on TinyMCE, but im only passing the params variable to JEditor, so i think this wont break the others editors. Codemirror, has not different mode

avatar javigomez
javigomez - comment - 28 Apr 2013

would you mind testing in other editors?

avatar fastslack
fastslack - comment - 28 Apr 2013

Codemirror seems to be fine with the patch applied, but mode="1" not work because Codemirror hasnt other modes

avatar javigomez
javigomez - comment - 28 Apr 2013

That Is what I guessed, the mode as far as I know is linked to the way TinyMCE works.

avatar fastslack
fastslack - comment - 28 Apr 2013

The only problem that i found is if we add 2 editors into a form and 2 differents modes like:

    <field name="test_instructions" type="editor" mode="0" buttons="true" hide="pagebreak,readmore,article"
        class="inputbox"
        filter="JComponentHelper::filterText"
        label="COM_BUGS_FIELD_TEST_INSTRUCTIONS" description="COM_BUGS_FIELD_TEST_INSTRUCTIONS_DESC" />

    <field name="description" type="editor" mode="2" buttons="true" hide="pagebreak,readmore,article"
        class="inputbox"
        filter="JComponentHelper::filterText"
        label="COM_BUGS_FIELD_DESCRIPTION" description="COM_BUGS_FIELD_DESCRIPTION_DESC" />

Both editor modes will be setted with the first mode (mode=0), i think its related with the way of how the JEditor instances are managed.

avatar nicksavov
nicksavov - comment - 30 Apr 2013

Thanks for coding this, Matias!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Matias!

avatar nicksavov
nicksavov - comment - 1 May 2013

Thanks Matias! :)

avatar brianteeman
brianteeman - comment - 23 Jul 2014

Closed as per comment on joomlacode

avatar brianteeman brianteeman - close - 23 Jul 2014

Add a Comment

Login with GitHub to post a comment