? Success

User tests: Successful: Unsuccessful:

avatar shur
shur
27 May 2016

One more inconsistency between updated Joomla site and freshly installed Joomla site.

Testing Instructions

1) Install Joomla 3.2.0 or earlier version.
2) Update to Joomla 3.6.0
3) Go to Extensions > Languages > Content Languages

Expected result

We must see Access: Public (as in freshly installed Joomla 3.6.0).
languages-english-access-j360-clean-install

Actual result

But we see Access: not set
languages-english-access-j320-to-j360

This PR fixes this inconsistency for English language access field.
Exploring the problem I discovered when this inconsistency was made #2714

avatar shur shur - open - 27 May 2016
avatar shur shur - change - 27 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 27 May 2016

Won't this mean that if a language has been set to anything other than public it will be changed on an update.

avatar shur
shur - comment - 27 May 2016

I have already considered that this access field can be changed. That's why I made a restriction:
ANDaccess= 0 to apply changes only in case when access is not set.

avatar brianteeman brianteeman - change - 27 May 2016
Category MS SQL Postgresql SQL
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 May 2016

i think it would be better to have that change in new sql files.

Also since a user can easily change the language title, wouldn't be better to change all languages that have access level of '0'? (there is no access level with 0 id)

UPDATE `#__languages` SET `access` = 1 WHERE `access` = 0;

Even then, a issue that remains is if the user somehow deleted the view access level with the id 1 (Public). Probably that's a really wild scenario since for deleting the Public access level you need to have no content with Public access level.

avatar Bakual
Bakual - comment - 27 May 2016

Isn't that a known issue for updated sites and you actually should have a post-install message about it?

Setting it to 1 isn't the correct thing to do. The access level with the id 1 can be anything. It just happens to be "public" on most sites because it's preinstalled this way, but you can change that.
That's why we decided back then to not have an update SQL but a postinstall message.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 May 2016

yeah, @Bakual is right IMO.

avatar brianteeman
brianteeman - comment - 27 May 2016

I knew there was a message just couldn't find it. Thanks

avatar Bakual
Bakual - comment - 27 May 2016

I'm closing this as a known issue which will not be fixed.
See also https://docs.joomla.org/J3.x:Infinite_error_loop_on_multilanguage_sites

avatar Bakual Bakual - change - 27 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-27 19:08:50
Closed_By Bakual
avatar Bakual Bakual - close - 27 May 2016
avatar Bakual Bakual - close - 27 May 2016
avatar infograf768
infograf768 - comment - 27 May 2016

also, we prvented an error in the languagefilter. see #6194

Add a Comment

Login with GitHub to post a comment