Feeling Lucky
?
[#10632] - [JDocumentRendererHtmlHead] only add the type attribute in the new script options if it's not an html5 page
- Closed
- 3 Sep 2016
- Medium
- Build: staging
- # 10632
- Diff
- andrepereiradasilva:patch-13
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
#9843 removed all the type attributes in html5 pages if they are the default html5 types for js/css.
But #3072 added a new script options render to JDocument renderer for HTML head.
For consistency, this simple PR does the same for the new script options.
Testing Instructions
Very simple PR. Code review.
Or ... you can follow the same test instructions as #9843 and #3072.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
grhcj
- comment
- 27 Jun 2016
I have tested this item
Code review and comparison with #3072.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 27 Jun 2016
| Labels |
Added:
?
|
||
roland-d
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-03 18:18:33 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on b4d0025
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632.