? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
25 May 2016

Summary of Changes

As discussed in #9987 (comment) this PR changes the menu type to the menu title in the menuitem form field.

Before
image

After
image

Testing Instructions

  1. Add this to one of the xmls (this will create 5 fields with menu items selector):
<field name="test1" type="menuitem"></field>
<field name="test2" type="menuitem" menu_type="aboutjoomla"></field>
<field name="test3" type="menuitem" language="*"></field>
<field name="test4" type="menuitem" disable="separator,alias,heading,url"></field>
<field name="test5" type="menuitem" published="0,1"></field>
  1. Check the fields show the menu type and not the menu title
  2. Apply patch
  3. Check they now show the menu title and work as before.
avatar andrepereiradasilva andrepereiradasilva - open - 25 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 25 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 26 May 2016
Category Administration UI/UX
avatar infograf768 infograf768 - test_item - 26 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 26 May 2016

I have tested this item successfully on 72c51a6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10625.

avatar brianteeman brianteeman - test_item - 26 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 May 2016

I have tested this item successfully on 72c51a6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10625.

avatar brianteeman brianteeman - change - 26 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 26 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10625.

avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 26 May 2016
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 26 May 2016

Thank you @andrepereiradasilva and testers!

avatar Kubik-Rubik Kubik-Rubik - close - 26 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 26 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 May 2016
avatar Kubik-Rubik Kubik-Rubik - reference | 440e751 - 26 May 16
avatar Kubik-Rubik Kubik-Rubik - merge - 26 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 26 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-26 17:10:46
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 26 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment