[#10622] - Component config: Improve and fix code style, hidden field + Add style for fieldset description
- Fixed in Code Base
- 25 Jun 2016
- Medium
- Build: staging
- # 10622
- Diff
- JoomliC:Add-style-alert-info-for-fieldset-description-in-component-config
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Fix code style
- Fix hidden field (no html to be rendered when field is hidden, to prevent empty lines (due to css classes for fields)
- Add style alert-info + icon for the description of a fieldset (description in top of each tab, when filled)
Testing Instructions
Test for fieldset description style:
- Go to any component configuration page (Options) and check description has now an alert-info look
Before Patch:
After Patch:
Test for hidden fields fix:
- To test fix for hidden fields, add in a config.xml those lines :
<field
name="hidden1"
type="hidden"
default="1"
/>
<field
name="hidden2"
type="hidden"
default="1"
/>
<field
name="hidden3"
type="hidden"
default="1"
/>
<field
name="hidden4"
type="hidden"
default="1"
/>
Before Patch:
After Patch:
- You can control after save, that hidden fields are saved in the database (#__extensions > component params)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style Components |
Actually, not related to your Pr, but i think that message is not correct.
I mean the category can also override article settings.
Exactly: nothing related to this PR, as screenshot is just an example ;-)
you're right. i should have read the HTML coding standard before. It seems all ok.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10622.
@andrepereiradasilva Thanks for testing!
you're right. i should have read the HTML coding standard before. It seems all ok.
Not exactly what i meant, but i asked to be sure you understand it as i did for HTML code standards, and so that we agree! ;-)
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10622.
Tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10622.
| Status | Pending | ⇒ | Ready to Commit |
RTC based on testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10622.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-25 12:55:49 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10622.
Actually, not related to your Pr, but i think that message is not correct.
I mean the category can also override article settings.