? Success
Pull Request for # 10618

User tests: Successful: Unsuccessful:

avatar alikon
alikon
25 May 2016

Pull Request for Issue #10618 .

Summary of Changes

SQL error (there is no table with p alias in the query)

Testing Instructions

see #10618

avatar alikon alikon - open - 25 May 2016
avatar alikon alikon - change - 25 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 May 2016
Category MS SQL Postgresql SQL
avatar brianteeman brianteeman - change - 25 May 2016
Rel_Number 0 10618
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 25 May 2016
Category MS SQL Postgresql SQL Components
avatar andrepereiradasilva andrepereiradasilva - test_item - 25 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 25 May 2016

I have tested this item successfully on a7ab3ff


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10620.

avatar sovainfo
sovainfo - comment - 25 May 2016

Could someone provide proper test instructions? Wonder what is tested!
Haven't been able to find its use, sounds like these lines can be removed. Including the duplicate lines in populateState, no need to do that twice, so one set can be removed anyway, but expect them to be obsolete both. Including its line (159) in getStoreId.

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 May 2016

Go to menu items and add &filter[parent_id]=PARENT_MENU_ITEM_ID to the URL.
Where PARENT_MENU_ITEM_ID is a menu item parent id.

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 May 2016

soemthing like /administrator/index.php?option=com_menus&view=items&filter[parent_id]=277

before patch 500 error
after patch shown the child menu items

avatar sovainfo
sovainfo - comment - 25 May 2016

Considering the view doesn't provide this functionality, it shouldn't be accepted on the url.

avatar andrepereiradasilva
andrepereiradasilva - comment - 25 May 2016

this is one of those "hidden" filters in the models.
You have similiar in other models also.

avatar sovainfo
sovainfo - comment - 25 May 2016

@andrepereiradasilva Thanks very much for the information, appreciated!
@alikon See my PR#21

avatar sovainfo sovainfo - test_item - 25 May 2016 - Tested successfully
avatar sovainfo
sovainfo - comment - 25 May 2016

I have tested this item successfully on a7ab3ff

Works as intended.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10620.

avatar infograf768 infograf768 - change - 25 May 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 May 2016

rtc. thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10620.

avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 May 2016
Milestone Added:
avatar roland-d roland-d - close - 25 May 2016
avatar roland-d roland-d - merge - 25 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 25 May 2016
avatar roland-d roland-d - reference | c792e6f - 25 May 16
avatar roland-d roland-d - merge - 25 May 2016
avatar roland-d roland-d - close - 25 May 2016
avatar roland-d roland-d - change - 25 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-25 20:21:41
Closed_By roland-d
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 25 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment