? Success

User tests: Successful: Unsuccessful:

avatar jsubri
jsubri
24 May 2016

Pull Request for a regression, 3.6.0-alpha TOS do not show-up properly anymore
capture

Summary of Changes

Recent update in file "plugins\user\profile\profile.php" renamed the "fields" directory in "field" and removed the JFormHelper::addFieldPath. Re-added back that line with proper directory.

JFormHelper::addFieldPath(DIR . '/field');

Testing Instructions

Ensure TOS is working with e.g captcha, association...

avatar jsubri jsubri - open - 24 May 2016
avatar jsubri jsubri - change - 24 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2016
Labels Added: ?
avatar mbabker
mbabker - comment - 24 May 2016

Where's it being loaded without that field? #9796 purposefully changed it so that certain conditions would automatically add the required lookup path.

avatar zero-24 zero-24 - change - 24 May 2016
Category Fields Front End
avatar zero-24 zero-24 - change - 24 May 2016
Priority Medium Urgent
avatar zero-24 zero-24 - change - 24 May 2016
Easy No Yes
avatar zero-24 zero-24 - change - 24 May 2016
Priority Urgent Medium
avatar jsubri
jsubri - comment - 24 May 2016

index.php/component/users/?view=registration is not loading the field

avatar jsubri jsubri - change - 24 May 2016
The description was changed
avatar infograf768
infograf768 - comment - 24 May 2016

I confirm the issue and the solution.

Also, the former "fields" folder and file are not deleted in script.php


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10615.

avatar infograf768
infograf768 - comment - 24 May 2016

The issue also concerns DOB.

I modify title


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10615.

avatar infograf768 infograf768 - change - 24 May 2016
Title
regression: re-adding tos in front-end
regression: re-adding tos and dob in front-end
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2016
Title
regression: re-adding tos in front-end
regression: re-adding tos and dob in front-end
avatar infograf768 infograf768 - test_item - 24 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 24 May 2016

I have tested this item successfully on 7da21ea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10615.

avatar infograf768
infograf768 - comment - 25 May 2016

@dgt41 @mbabker
the issue in this case and why it does not work for profile is because the specific form itself (profiles.xml) is not in the root of the plugin but in a subfolder /profiles/profiles.xml. It is used only when registering in frontend or creating a user in back-end. The general code to load fields from a field folder in the com_plugin model will only load the field type for the basic plugin xml in its root, i.e. here for user/profile/profile.xml

avatar brianteeman brianteeman - test_item - 27 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 May 2016

I have tested this item successfully on 7da21ea

Replicated the issue on both fields
PR fixes it


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10615.

avatar brianteeman brianteeman - change - 27 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 27 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10615.

avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 27 May 2016
Milestone Added:
avatar roland-d roland-d - change - 28 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-28 09:14:04
Closed_By roland-d
avatar roland-d roland-d - close - 28 May 2016
avatar roland-d roland-d - merge - 28 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 28 May 2016
avatar roland-d roland-d - reference | 42cf6bd - 28 May 16
avatar roland-d roland-d - merge - 28 May 2016
avatar roland-d roland-d - close - 28 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 28 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment