PR looks fine from review.
I have added the release-blocker label as it should go into 3.6.0. If not, we can as well close it ????

cc @richard67
@Bakual @shur see #9579

@wojsmol Doesn't look related to this issue here.

@Bakual see the discussion from #9579 (comment) mainly between @richard67 and @andrepereiradasilva

Yeah, that's a know problem with database fixer, that it does not handle insert/update/delete statements (DML). So those changes will not be applied when not using Joomla! Update Component but one of the "copy or extract the files and then use the db fixer" methos.

A solution could be to collect changes which can be applied always without doing any harm, like those in this PR or those by @andrepereiradasilva for changing update urls to https, in a separate sql script which would be run at the end of a db fix in any case. I currently am waiting for feedback by @wilsonge from PLT discussion about other stuff related to udpating problems (timeout errors), maybe he can discuss that idea, too.

Also a solution as alternative or in addition to a special script could be to have a button "Finalise Update" in the db fixer view, which can be used after one of these update methods I mentioned to run the schema updates if their file version in greater than the schema version in db, or to extend the function for the existing Fix button by running them if schema version in db is not equal to the youngest schema update file.

For now people who make PRs like this or andre's have to live with that like it is now, because that is the official way to provide such DB updates.

As long as not everybody has a 3.6 or later where the new update functions are included, some people will need these update methods I mentioned and so they can not be abandoned, and so something has to be done as soon as possible.

A solution could be to collect changes which can be applied always without doing any harm, like those in this PR

The ones in this PR are probably harmless, but frankly there are some INSERT/UPDATE statements we've shipped that have broken tables (i.e. every INSERT to the menu table has broken the nested set structuring). So I wouldn't even call all the DML statements "safe".

It's actually not a known "problem". The database fix just isn't supposed to run those statements.
The problem is more running an unsupported update path, which is manually updating the files and running database fix. This is actually a hackish way to update Joomla.
The supported paths running through com_joomlaupdate will take care of those insert/update/delete statements just fine.

I don't think we need to change anything in the database fix method to support that hackish update method.

@mbabker Sure, only such statements which do not do any harm I meant, not ALL DML.

I have tested this item ✅ successfully on c111a94

on code review