Feeling Lucky
?
[#10607] - Fix modal header alignment if parent is centered
- Fixed in Code Base
- 24 May 2016
- Medium
- Build: staging
- # 10607
- Diff
- JoomliC:Fix-modal-header-alignment
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
When the parent container has class center, where a modal is rendered, the modal-header is centered too (and should be left on LTR and right on RTL).
Summary of Changes
- Add text-align in Isis template and rtl less files
Testing Instructions
- Go to
Menus>Manage - Click on "Module" button to select a module to be edited (open a modal).
- The Modal Header should be now aligned left (right on RTL).
Before Patch:
After Patch:
infograf768
- comment
- 23 May 2016
hathor?
JoomliC
- comment
- 23 May 2016
@infograf768 do you have tested with Hathor ?
There's not this issue with Hathor, but other ones...
No need for this change in Hathor, as the container div (column) is not centered as it is in Isis. ;-)
So the issue is only with Isis (column modules centered)
| Category | ⇒ | Templates (admin) |
vinespie
- comment
- 23 May 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10607.
| Status | New | ⇒ | Ready to Commit |
brianteeman
- comment
- 23 May 2016
brianteeman
- comment
- 23 May 2016
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-24 07:59:47 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 24 May 2016
Thanks everybody
I have tested this item✅ successfully on 774606c
on english and arabic
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10607.