? Success

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
21 May 2016

Summary of Changes

Code style changes for mod_custom

Testing Instructions

code review

cc @JoomliC @andrepereiradasilva

avatar wojsmol wojsmol - open - 21 May 2016
avatar wojsmol wojsmol - change - 21 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2016
Labels Added: ?
avatar wojsmol wojsmol - change - 22 May 2016
The description was changed
avatar brianteeman brianteeman - change - 22 May 2016
Category Code style
avatar andrepereiradasilva andrepereiradasilva - test_item - 22 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 May 2016

I have tested this item successfully on eb07e9f

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10579.

avatar brianteeman brianteeman - test_item - 23 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 23 May 2016

I have tested this item successfully on eb07e9f

@wojsmol in future can you do one pull request for any other changes instead of one per file. Now that we have agreed the structure of the changes it will make life easier if any more fixes are done in a single PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10579.

avatar brianteeman brianteeman - change - 23 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 23 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10579.

avatar joomla-cms-bot joomla-cms-bot - change - 23 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 23 May 2016
Milestone Added:
avatar JoomliC JoomliC - test_item - 23 May 2016 - Tested successfully
avatar roland-d roland-d - change - 26 May 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-05-26 06:41:37
Closed_By roland-d
avatar roland-d roland-d - close - 26 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment