[#10555] - [com_menus] items view: cleaner tree prefix
- Fixed in Code Base
- 25 May 2016
- Medium
- Build: staging
- # 10555
- Diff
- andrepereiradasilva:menus-better-tree
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR does for com_menus items view, the same visual change as the other views that have tree structures.
Also adjusted a little the tree prefix layout to be even more clean and be more adaptabe to multiline contexts.
Before
After
Testing Instructions
- Use latest staging and go to "Menus" -> (Any Menu with levels)
- Check the "Before" scenario
- Apply patch
- Check the "After" scenario.
- Check the adjusted tree layout in ACL Permissions, User Groups, Categories, Debug permission report, etc
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Templates (admin) UI/UX |
After patch applied
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
I have tested this item
Checked issue in menus before patch & confirm all OK after patch - see comments for screenshot.
All works OK & nice improvement
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
Nice Improvment :) Tested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
@andrepereiradasilva sorry this is not correct. You have missed out the character immediately before the menu item name as seen in the other tree edits eg #10526
@brianteeman as talked please test the patch and see all views as PR description.
@andrepereiradasilva is this ready for testing again? I just tested again after clearing caches & fetching all new data in patch tester & looks same at the moment - same as my tested screenshot above.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
@sandstorm871 no need to test. i didn't change anything. just reponding to @brianteeman
@andrepereiradasilva if all the trees are now looking like this one then i dont like it. its not what we agreed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
ok brian. will remove the layout change from this PR and make a new PR to propose that change in the layout file.
This PR has received new commits.
CC: @freshweb, @sandstorm871
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
ok done. layout changes removed
Tested again & looks OK.
This is same @brianteeman showed me at #JAB16
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
I have tested this item
As per my comment & screenshot below, tested OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.
Please add milestone to 3.6.0
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-25 20:13:18 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item✅ successfully on e524c23
Tested on Mac - Chrome (Version 50.0.2661.102 (64-bit) )
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10555.