[#10547] - [com_menus] menus acl: don't allow to delete if user doesn't have permission to delete in that menu type
- Fixed in Code Base
- 28 May 2016
- Medium
- Build: staging
- # 10547
- Diff
- andrepereiradasilva:patch-17
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Some ACL in the menus list view aren't working quite right:
- If the user can't delete a particular menu type or is menu items it shouldn't be allowed to delete the menu type.
Testing Instructions
Create a user groups "testgroup" (child of "Administrator" user group)
Go to Menus -> Manager, create a "menu-dont-delete" menu type and set the "testgroup" group to have no permission (Denied) to "Delete"
Create a user "testuser" and add it only to "testgroup"
Open a new private browser window and login to backend with "testuser".
Go to menu Menus -> Manage
-
Try to delete the "menu-dont-delete". The menu is deleted!
It shouldn't since you removed that permission in "2."
Apply patch. Repeat step 2. and 6. all good, a error message will appear.
You can also try with several menus at the same time.
@bembelimen @infograf768 please test
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | ACL |
I have tested this item
Tested on 21-05-2016 and worked fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Information Required |
| Labels | |||
Taking RTC off for now until updated.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
| Labels |
Removed:
?
|
||
@roland-d
Can you merge after changing
// Make sure the item ids are integers
//jimport('joomla.utilities.arrayhelper'); // DELETE
//JArrayHelper::toInteger($cids); // DELETE
$cids = Joomla\Utilities\ArrayHelper::toInteger($cids); // ADD
as @andrepereiradasilva Is unavailable for now.
i will do it
This PR has received new commits.
CC: @Cybernary, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
This PR has received new commits.
CC: @Cybernary, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
done
I have tested this item
One more tester.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
@Cybernary
We need another test here.
| Status | Information Required | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-28 09:38:14 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item✅ successfully on 72054a0
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10547.