[#10539] - remove insert module button
- Closed
- 3 Aug 2016
- Medium
- Build: staging
- # 10539
- Diff
- brianteeman:module-button
User tests: Successful: Unsuccessful:
Pull Request for Issue 10525 .
Summary of Changes
This PR removes the ability to insert a module into
Contact Form information
Tag description
Category description
Banner Description
Testing Instructions
Open above forms and see that the module button is not present in the tinymce toolbar
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 10525 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Components Plugins |
Yeah I will sort it later today
On 18 May 2016 at 06:36, zero-24 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman your branch has merge
conflicts.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10539 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
just because it works doesnt mean its a good idea ;)
On 18 May 2016 at 15:39, andrepereiradasilva notifications@github.com
wrote:
in categories description the {loadmodule...} is working. in contacts
will work with #10541 #10541.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10539 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
just because it works doesnt mean its a good idea ;)
maybe not for contact, i am not sure, will it create problems ? (i really don't know) i thought a reason for adding plugin event triggering to the contact view was such usage
categories description some users, use loadmodule already, is it problematic ?
Regardless of the module button,
the plugin triggering in contact view should be fixed,
now it is triggering on empty text, which is pointless
just because it works doesnt mean its a good idea ;)
Why not? I'm not saying that's a brilliant idea, but lots of people use it.
I'm not sure about all the PR, I mean category description. Many users make category blog page much more informative and attractive with modules inserted with loadposition in description.
Why removing the possibility that is widely used?
I have tested this item
Button gone in described forms.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10539.
I have tested this item
Module button removed from TinyMCE editor in the said forms.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10539.
| Status | Pending | ⇒ | Needs Review |
Setting to needs review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10539.
| Category | Components Plugins | ⇒ | Administration Components Tags Front End |
Closing this PR here
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-03 15:57:17 |
| Closed_By | ⇒ | brianteeman |
New PR is #11419 based on feedback above - thanks for testing - sorry you will have to test the new pr
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10539.
@brianteeman your branch has merge conflicts.