Feeling Lucky
?
[#10504] - [com_contact] Coding standards form xml + correction wrong closing tags
- Fixed in Code Base
- 21 May 2016
- Medium
- Build: staging
- # 10504
- Diff
- JoomliC:Coding-standards-com_contact-XML
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Code standards (https://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md) + correction closing tags, form xml files com_contact
Summary of Changes
config.xml
- Code standards
- Add emtpy line before each opening tag (readability)
- Fix wrong field closing tag :
image
models/forms/contact.xml
- Code standards
- Add emtpy line before each opening tag (readability)
- Fix wrong field closing tag :
tags - Fix mix space/tabs for a few indents
models/forms/filter_contacts.xml
- Code standards
- Add emtpy line before each opening tag (readability)
Testing Instructions
- code review
- apply and test all is working as before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
freshweb
- comment
- 21 May 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10504.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 21 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-21 16:35:48 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 21 May 2016
Thanks everybody
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10504.
I have tested this item
successfully on 5e84871
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10504.