Feeling Lucky
?
[#10488] - [plg_finder_categories]Code style
- Fixed in Code Base
- 18 May 2016
- Medium
- Build: staging
- # 10488
- Diff
- wojsmol:plg_finder_categories-cs
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Code style changes forplg_finder_categories
Testing Instructions
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
JoomliC
- comment
- 17 May 2016
@wojsmol Even if it's valid in a php code, i think here, it uses Joomla library __clone() function to prevent fatal error, and will control to be sure we have an object : https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/query.php#L1396
Would need confirmation from PLT, maybe @wilsonge could confirm ?
mbabker
- comment
- 17 May 2016
__clone() is a PHP magic method and the method you linked isn't being called in this case. clone $this is a language construct in PHP, not a method call.
JoomliC
- comment
- 17 May 2016
I have tested this item 
successfully on a8d3d14
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10488.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-18 08:52:13 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
I have tested this item
successfully on a8d3d14
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10488.