Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10480] - Only convert to an array when it is a string for mssql.

? Success
Pull Request for # 10327

User tests: Successful: Unsuccessful:

avatar sovainfo
sovainfo
15 May 2016

Pull Request for Issue 10327 .

Summary of Changes

Only convert to an array when it is a string. The method can be called with either a string or an array. When calling with an array it produces 4 warnings, see issue!

Testing Instructions

Use joomla on mssql.

avatar sovainfo sovainfo - open - 15 May 2016
avatar sovainfo sovainfo - change - 15 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2016
Labels Added: ?
avatar sovainfo sovainfo - change - 15 May 2016
Title
…
Update sqlsrv.php
Only convert to an array when it is a string for mssql.
avatar sovainfo sovainfo - change - 15 May 2016
Title
…
Update sqlsrv.php
Only convert to an array when it is a string for mssql.
avatar brianteeman brianteeman - change - 15 May 2016
Rel_Number 0 ⇒ 10327
Relation Type ⇒ Pull Request for
avatar brianteeman brianteeman - change - 15 May 2016
Category ⇒ MS SQL
avatar waader waader - test_item - 17 May 2016 - Tested successfully
avatar waader
waader - comment - 17 May 2016

I have tested this item :white_check_mark: successfully on 7319cd3

Thanks sovainfo!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10480.

avatar alikon alikon - test_item - 26 May 2016 - Tested successfully
avatar alikon
alikon - comment - 26 May 2016

I have tested this item ✅ successfully on 7319cd3

on code review

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10480.

avatar brianteeman brianteeman - change - 26 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 26 May 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10480.

avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 26 May 2016
Milestone Added:
avatar roland-d roland-d - change - 28 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-28 07:57:26
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 28 May 2016
avatar roland-d roland-d - merge - 28 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 28 May 2016
avatar roland-d roland-d - reference | f598e4e - 28 May 16
avatar roland-d roland-d - merge - 28 May 2016
avatar roland-d roland-d - close - 28 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 28 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 28 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment