Feeling Lucky
?
[#10466] - [JApplicationCms] Add isHttpsForced method
- Closed
- 5 Sep 2016
- Medium
- Build: staging
- # 10466
- Diff
- andrepereiradasilva:patch-15
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR is for adding a new method isHttpsForced to JApplicationCms.
This method can be used to check if the current (or given) client is configured (in the global config) to force HTTPS usage.
Please note this is different from JApplicationWeb::isSSLConnection() that does a very different thing (uses the server environment variables to check if the current page is served trough HTTPS).
This PR also, as a PoC, applies this method to determining if the session cookie should be a secure cookie or not, replacing the old similiar code.
Testing Instructions
To check this method is working.
Code review, or:
Apply patch
For admin client (backend)
- Go to isis
index.phpfile and afterdefined('_JEXEC') or die;add:
$app = JFactory::getApplication();
$app->enqueueMessage($app->isHttpsForced() ? 'HTTPS is forced' : '', 'notice');- Load any backend page. It will now give a "HTTPS is forced" message if you have "Force HTTPS" in global config set to "Entire Site" or "Administrator Only"
For site client (frontend)
- Add the same code above but now to protostar
index.phpfile - Load any frontend page. It will now give a "HTTPS is forced" message if you have "Force HTTPS" in global config set to "Entire Site"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-05 21:55:39 |
| Closed_By | ⇒ | andrepereiradasilva |
closing for last of interest