Feeling Lucky
?
[#10464] - [plg_system_sef] Add sef URI when using srcset attribute
- Fixed in Code Base
- 20 May 2016
- Medium
- Build: staging
- # 10464
- Diff
- andrepereiradasilva:patch-9
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
Pull Request for
# 10463
User tests: Successful: Unsuccessful:
Pull Request for Issue #10463.
Summary of Changes
See #10463
Testing Instructions
- Use SEF URL (global config + sef system plugin)
- Add an image in an article with this html (or equivalent)
<img src="images/sampledata/parks/banner_cradle.jpg" srcset="images/sampledata/parks/banner_cradle.jpg" alt="yyy" />- Check in the frontend the srcset attribute URL is NOT converted to SEF URL (misses the base path).
- Apply patch
- Check in the frontend the srcset attribute URL is converted to SEF URL (in this example, should be
/images/sampledata/parks/banner_cradle.jpgor/<sitepath>/images/sampledata/parks/banner_cradle.jpg)
Please note this will not solve all srcset possibilities, only for cases like the one described in the issue (path to one image).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Plugins Router / SEF |
| Rel_Number | 0 | ⇒ | 10463 |
| Relation Type | ⇒ | Pull Request for |
brianteeman
- comment
- 16 May 2016
I have tested this item 
successfully on 8474310
Issue confirmed and patch fixes it
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464.
infograf768
- comment
- 18 May 2016
I have tested this item successfully on 8474310
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 18 May 2016
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10464.
| Labels |
Added:
?
|
||
infograf768
- comment
- 18 May 2016
for 3.6.0 I guess.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-20 09:26:22 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 20 May 2016
Thanks everybody
@zero-24 this PR is not for code style of the SEF plugin ...