[#10462] - Make including pw in mail to user optional when created by admin
- Closed
- 24 Jun 2016
- Medium
- Build: staging
- # 10462
- Diff
- sovainfo:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #10376 .
Summary of Changes
When creating user accounts as administrator and sending an email, it is now optional to include the password in the mail.
This is configurable on the plugin. Sending the email was already optional.
When sending emails, including the password in the email is now optional.
Testing Instructions
Apply this patch
As administrator create an user account.
Verify that the password is included in the mail.
Configure plugin User - Joomla to exlude the password.
Create an user account.
Verify that the password in not in the mail.
This closes issue #10376
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels | |||
| Category | ⇒ | Authentication Language & Strings |
| Labels | |||
Thank you, @wojsmol @andrepereiradasilva
I have tested this item 
successfully on dd4e457
Tested successfully. All works as described.
Without the patch: username and password will be send by email.
With the patch applied: send password is optional and will not be send if ticked 'No'.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462.
I dont understand why you did it this way in the plugin and didnt use the existing option
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462.
Disagree on using the option meant for the registration process. The registration process is different from the account creation process by an administrator. Consider that you should be able to configure that setting for each process. The settings can be the same or different. Setting it for one process has no bearing on the other. That is the functionality I think should be provided.
This PR has received new commits.
CC: @BurtNL
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462.
This PR has received new commits.
CC: @BurtNL
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10462.
Tried to fix the conflicts but apparently failed:
- copy content staging/joomla.xml
- add field
- edit patch-5/joomla.xml Same thing for joomla.php
Maybe somebody else has more luck!
@wojsmol Thanks for trying to help. Using GitHub for Firefox exclusively, haven't found proper way to resolve conflicts, revert or rebase. The only way I know is to close and create a new PR.
Very disappointing if that is what needs to be done. Will wait for feedback before giving up and closing!
@sovainfo See staging...wojsmol:10462-rebase - current staging with thIs PR.
Can't fix the conflicts!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-06-24 22:05:58 |
| Closed_By | ⇒ | sovainfo |
Yes, probably after the release of J360.
@sovainfo see sovainfo#3