? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
14 May 2016

Pull Request for Issue #10458 (wrong redirect after save menu item).

Summary of Changes

This issue exists at least in 3.5.1 (didn't check older versions).

When we create a menu item by selecting "Add new Menu Item" in the admin menu. After we create and save the menu item, the system in not redirecting to the list of menu items of the menu where we created the menu item.

This PR solves that.

Testing Instructions

You check that issue with this:
1. Use latest staging
2. Logout from backend
3. Login in the backend
4. Go directly to the admin menu Menus -> (Any Menu you want) -> Add new menu item
6. Now create the menu item as ususal. Save and close
7 .Notice you are redirect to the "All Menu Items" menu items list view, not the list view of the menu you created the menu item.
8. Now select a list of menu items of another menu.
9. Go again to admin menu Menus -> (Any Menu you want except the one you are in) -> Add new menu item
10. Now create the menu item as ususal. Save and close
11 .Notice you are redirect to the old menu you here menu items list view, not the list view of the menu you created the menu item.
12. Apply patch, repeat tests and notice the redirect is now ok.

avatar andrepereiradasilva andrepereiradasilva - open - 14 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
Title
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" (or direct URL)
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" or direct URL (solves #10458 - redirect part)
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
Title
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" (or direct URL)
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" or direct URL (solves #10458 - redirect part)
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 14 May 2016
The description was changed
avatar Webdongle Webdongle - test_item - 14 May 2016 - Tested successfully
avatar Webdongle
Webdongle - comment - 14 May 2016

I have tested this item :white_check_mark: successfully on d365745

Applied patch
Clicked create menu from the Menus menu
Clicked Cancel and the page returned to the menu view of the menu that the create menu was selected from
FULL SUCCESS

Logged in admin with another browser (to avoid confusing sessions on the first Browser)
Clicked create menu from the Menus menu
Created a menu item and Saved it
Clicked close and the page returned to the menu view of the menu that the create menu was selected from
FULL SUCCESS

Logged in admin with another browser (to avoid confusing sessions on the first Browser)
Clicked create menu from the Menus menu
Created a menu item
Clicked save&close and the page returned to the menu view of the menu that the create menu was selected from
FULL SUCCESS

Logged in admin with another browser (to avoid confusing sessions on the first Browser)
Clicked create menu from the Menus menu
Created a menu item
Clicked save&new
Clicked cancel and the page returned to the menu view of the menu that the create menu was selected from
FULL SUCCESS


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10460.

avatar brianteeman brianteeman - change - 14 May 2016
Title
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" or direct URL (solves #10458 - redirect part)
[com_menus] items view: Force redirect to menu items list view after creating menu item with "Add new Menu Item" or direct URL (solves #10458 - redirect part)
avatar brianteeman brianteeman - change - 14 May 2016
Category Administration
avatar infograf768 infograf768 - test_item - 15 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 15 May 2016

I have tested this item :white_check_mark: successfully on d365745

Both codes work OK here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10460.

avatar brianteeman brianteeman - change - 15 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10460.

avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 15 May 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - change - 16 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 16 May 2016
The description was changed
avatar BurtNL BurtNL - test_item - 17 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 17 May 2016

I have tested this item :white_check_mark: successfully on d365745

I have applied this patch on the latest staging together with #10459 and it is working as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10460.

avatar rdeutz rdeutz - change - 17 May 2016
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 17 May 2016

@andrepereiradasilva @wilsonge could you both figure out what is wrong or right and how we move forward with it, removing RTC for the moment

avatar rdeutz rdeutz - change - 17 May 2016
Status Ready to Commit Needs Review
Labels
avatar rdeutz
rdeutz - comment - 17 May 2016

da


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10460.

avatar joomla-cms-bot joomla-cms-bot - change - 17 May 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 24 May 2016

bump
@wilsonge @andrepereiradasilva
Please decide.

avatar andrepereiradasilva
andrepereiradasilva - comment - 24 May 2016

waiting for @wilsonge on this one.
Nothing for me to decide.

avatar wilsonge wilsonge - close - 26 May 2016
avatar wilsonge wilsonge - merge - 26 May 2016
avatar wilsonge wilsonge - change - 26 May 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-26 09:27:50
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment