Feeling Lucky
?
[#10454] - Code Style
- Fixed in Code Base
- 25 May 2016
- Medium
- Build: staging
- # 10454
- Diff
- photodude:patch-4
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Code Style improvements .
Summary of Changes
- When splitting array definitions onto several lines, the last value should also have a trailing comma.
- Broke a few lines into multiline just for easier reading.
Testing Instructions
Can be merged by code review.
Testing if desired would be to apply the patch and then check that the system info panel works as expected in admin
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
zero-24
- comment
- 24 May 2016
I have not tested this item.
Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 24 May 2016
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
zero-24
- comment
- 25 May 2016
I have tested this item
lol. Thanks @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-25 20:04:43 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
roland-d
- comment
- 25 May 2016
Thanks everybody
photodude
- comment
- 25 May 2016
Thanks everyone
I have tested this item✅ successfully on c473205
tested component still works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10454.