[#10452] - Fix Notice on mod_menu
- Fixed in Code Base
- 25 May 2016
- Medium
- Build: staging
- # 10452
- Diff
- 810:fixmenu
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Notice: Only variables should be passed by reference in C:\wamp\www\develop\administrator\modules\mod_menu\tmpl\default_enabled.php on line 23
and many more notices.
Discovered by the new PHP7.0.7 RC1 version
Before that version the notices where never showed.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Modules |
&$node
This is used in 13 places in the codebase
FILE: .../travis/build/joomla/joomla-cms/administrator/modules/mod_menu/menu.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
52 | ERROR | Doc comment for var &$node does not match actual variable name
| | $node at position 1
--------------------------------------------------------------------------------
Kubik-Rubik
- | Milestone |
Added: |
||
What about JMenuNode &$child and JMenuNode &$parent in the same file?
I don't get any other notices. Just this function
Here is the bug report for PHP; It looks like there was edge case which allowed new object to be passed as reference, but which was fixed for PHP 7.0.7.
https://bugs.php.net/bug.php?id=72214
I recommend you to participate to the discussion if the fix should be postponed until 7.1 or if its fine to be fixed now.
I have tested this item 
successfully on f2fb7c4
Don't have php 7.0.7 RC but backend menu still works after patch in PHP 7.0.6.
So test is a success.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
This is not only an issue of php 7.0.7 RC.
I'm running php 7.0.6 (Siteground). On every site where I set Error Reporting in Global Configuration to Maximum I get these notice messages and my administrator gets crippled. I only get administrator functionality back after setting Error Reporting to Default again manually using FTP.
Files:
/administrator/modules/mod_menu/menu.php (line 94)
/administrator/modules/mod_menu/tmpl/default_enabled.php (lots of lines)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
I've tested fix c2c80d3 successfully on Joomla 3.5.1 running 7.0.6
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for fixing and testing!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-25 20:02:57 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
Thanks everybody
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
I have tested this item
Glad to have found this issue and its fix.
And tks to matias who gave the reference to this pull request in https://bugs.php.net/bug.php?id=72214&edit=3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.
Testers please note this is the Administrator module not the site module
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10452.