? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 May 2016

PR #10373 changed the name of the remember me cookie so it can be detected by reverse caching proxies. This is fine but means that all existing remember me cookies don't work anymore and all users will have to login fresh after the update.
While this isn't that big of a deal, we can still do better ????

Summary of Changes

This PR adds a fallback mechanism to the cookie plugins. If there is no cookie with the new name (prefixed with joomla_remember_me_), it will look for the old name and proceed with that one if found.
After a successfull login, the old cookie will be destroyed and a new one created with the prefixed name.

Testing Instructions

Ideally:

  • take a 3.5.1 installation
  • log in with remember me option activated
  • update to latest staging and apply this PR
  • close all browser windows to be sure all sessions are terminated
  • open the site again. You should still be logged in. Without this PR you would be logged out.

Hackish way since the testing is a bit complex

  • take latest staging and apply this PR
  • change https://github.com/Bakual/joomla-cms/blob/CookieFallback/plugins/authentication/cookie/cookie.php#L254 from $cookieName = 'joomla_remember_me_' . JUserHelper::getShortHashedUserAgent(); to $cookieName = JUserHelper::getShortHashedUserAgent();
  • log in with the option "remember me" activated. This should create a cookie with the old name (without prefix)
  • close all browser windows to kill all sessions
  • open the site again. You should still be logged in and the cookie got renamed to the new name (with prefix).
avatar Bakual Bakual - open - 12 May 2016
avatar Bakual Bakual - change - 12 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 May 2016
Category Plugins
avatar wilsonge wilsonge - change - 21 May 2016
Labels Added: ?
avatar wilsonge wilsonge - close - 30 May 2016
avatar wilsonge wilsonge - change - 30 May 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-30 22:55:47
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2016
avatar wilsonge wilsonge - merge - 30 May 2016
avatar wilsonge wilsonge - reference | ee00680 - 30 May 16
avatar wilsonge wilsonge - merge - 30 May 2016
avatar wilsonge wilsonge - close - 30 May 2016
avatar wilsonge
wilsonge - comment - 30 May 2016

Merged on review as we need this for the beta.

avatar wilsonge wilsonge - change - 30 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 8 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment