[#10425] - [com_config] Error?/Success? messages on save
- Fixed in Code Base
- 16 May 2016
- Medium
- Build: staging
- # 10425
- Diff
- andrepereiradasilva:com_config-save-messages-ux
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
In com_config when we get an error on save (ex: bad session token or no permission) we get a green (aka success) message.
This is a bad UX problem:
- Green messages are for success
- Blue messages are for information
- Yellow messages are for warnings
- Red messages are for errors or very importing stuff
This PR corrects that.
Testing Instructions
Code review, or, for instance:
1. (browser Tab 1) Go to global config form, don't save
2. (browser Tab 2) Open a new browser tab, go to backend, logout and login again
3. (browser Tab 1) Press "Save" or "Save and Close" in the global config to save.
4. You'll notice you get and invalid token message and the message is green and from a user perspective it's associated with action success.
5. Apply patch, repeat process 1 to 3. Now the message is red.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
I have tested this item 
successfully on d7b3fdb
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
@brianteeman @BurtNL thanks for testing!
I have tested this item successfully on d7b3fdb
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.
I was a bit late I just see 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.
thanks @richard67 another test in always good
all tests always welcome
On 11 May 2016 at 17:51, Richard Fath notifications@github.com wrote:
I was a bit late I just see [image:
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10425
https://issues.joomla.org/tracker/joomla-cms/10425.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10425 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
I will soon (in a few days) need testers for PR I am preparing, make utf8mb4 conversion use files with version numbers so not on every change all has to run, and make it handle extensions, too, so I am also working on a PR for weblinks to provide an example. Testers will be welcome, I'll let you know when my PR is ready.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 16:03:34 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on d7b3fdb
Good find
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10425.